Skip to content

fix: hide hyperlink when license path is invalid #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhduiy merged 1 commit into from
May 19, 2026
Merged

fix: hide hyperlink when license path is invalid #621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions qt6/src/qml/AboutDialog.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,12 @@ DialogWindow {
id: contentView
width: parent.width
implicitHeight: contentLayout.implicitHeight

D.LicenseInfoProvider {
id: licensePathChecker
path: control.licensePath
}

ColumnLayout {
id: contentLayout
spacing: 0
Expand Down Expand Up @@ -138,7 +144,13 @@ DialogWindow {
}
Label {
id: acknowledgmentsLabel
text: qsTr("Sincerely appreciate the %1 used.").arg(control.__websiteLinkTemplate.arg("-").arg(qsTr("open-source software")))
text: {
var softwareText = qsTr("open-source software");
if (licensePathChecker.valid)
return qsTr("Sincerely appreciate the %1 used.").arg(control.__websiteLinkTemplate.arg("-").arg(softwareText));
else
return qsTr("Sincerely appreciate the %1 used.").arg(softwareText);
}
textFormat: Text.RichText
Layout.fillWidth: true
font: D.DTK.fontManager.t8
Expand Down Expand Up @@ -173,7 +185,7 @@ DialogWindow {
id: licenseDialogLoader
active: false
sourceComponent: LicenseDialog {
licensePath: control.licensePath
licenseProvider: licensePathChecker
onClosing: function (close) {
licenseDialogLoader.active = false
}
Expand Down
6 changes: 1 addition & 5 deletions qt6/src/qml/LicenseDialog.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ DialogWindow {
height: 900
title: qsTr("open-source software")

property alias licensePath: licenseProvider.path
property D.LicenseInfoProvider licenseProvider

header: D.DialogTitleBar {
leftContent: Item {
Expand All @@ -37,10 +37,6 @@ DialogWindow {
implicitWidth: control.width - control.leftPadding - control.rightPadding
implicitHeight: control.height - DS.Style.dialogWindow.titleBarHeight - DS.Style.dialogWindow.contentHMargin

D.LicenseInfoProvider {
id: licenseProvider
}

StackView {
id: stackView
anchors.fill: parent
Expand Down
Loading