fix: hide hyperlink when license path is invalid#621
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @MyLeeJiEun, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
Hi @MyLeeJiEun. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1. Add D.LicenseInfoProvider to check license path validity in AboutDialog 2. Only display open-source software text as hyperlink when license path is valid 3. Pass LicenseInfoProvider instance to LicenseDialog instead of license path string Log: Fix open-source software acknowledgement text to only hyperlink when license info is available fix: 根据许可路径有效性条件显示超链接 1. 在关于对话框中添加 D.LicenseInfoProvider 检查许可路径有效性 2. 仅在许可路径有效时将开源软件文本显示为超链接 3. 将 LicenseInfoProvider 实例传递给许可对话框，替代路径字符串 Log: 修复开源软件致谢文本，仅在许可信息可用时显示为超链接 PMS: BUG-361031
MyLeeJiEun
force-pushed
the
fork-from-master-0519-fix-issue-361031
branch
from
4824c16 to
9e78761
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mhduiy, MyLeeJiEun The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/merge |
|
This pr cannot be merged! (status: unstable) |
3 participants
Log: Hide the open-source software hyperlink in the about dialog when license path is invalid
fix: 许可证路径无效时隐藏超链接
Log: 关于对话框中许可证路径无效时隐藏开源软件超链接
PMS: BUG-361031