Open
Conversation
Also clean up the code accordingly
Also refactor the code to use nested asyncio.gather() and remove unnecessary GRPC-object-to-dictionary methods
Use LRU cache and list compression plus join() instead of string concatenation
Calculates normalized identity value from 0.0 - 1.0 using existing levenshtein and jaccard metrics functions
…of just start and end
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the PR for the macro synteny paf microservice that I've been working on. The scope grew over time and so I apologize for how unwieldy this PR is. Please feel free to take your time reviewing it and we can always set up a dedicated time to discuss.