fix: fix dll_name for Authenticode signing in publish workflow#121
Merged
Conversation
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
joker23
approved these changes
Jul 1, 2026
kinyoklion
pushed a commit
that referenced
this pull request
Jul 1, 2026
🤖 I have created a release *beep* *boop* --- ## [5.3.1](5.3.0...5.3.1) (2026-07-01) ### Bug Fixes * fix dll_name for Authenticode signing in publish workflow ([#121](#121)) ([ac7c5a7](ac7c5a7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Version and documentation-only release; no application code changes in this PR. > > **Overview** > This is an automated **5.3.1** patch release: version is updated in `.release-please-manifest.json`, `LaunchDarkly.EventSource.csproj`, `PROVENANCE.md`, and `CHANGELOG.md`. > > There are **no library or runtime code changes** in this diff. The release notes document the already-merged fix ([#121](#121)) that corrects `dll_name` for Authenticode signing in the publish workflow (`LaunchDarkly.EventSource.dll` in `.github/workflows/publish.yml`). > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit dcc3ba6. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
kinyoklion
added a commit
to launchdarkly/dotnet-core
that referenced
this pull request
Jul 1, 2026
… assemblies (#303) **Related issues** - launchdarkly/dotnet-eventsource#121 — fixed incorrect `dll_name` in the publish workflow that prevented Authenticode signing **Describe the solution you've provided** Updates `LaunchDarkly.EventSource` from 5.3.0 → 5.3.1 in ServerSdk and from 5.2.1 → 5.3.1 in ClientSdk. Version 5.3.1 is the first release with correct Authenticode (DigiCert) signing — prior versions shipped unsigned due to a typo in the publish workflow. **Describe alternatives you've considered** N/A — this is a dependency bump to pick up correctly signed assemblies. **Additional context** No functional changes in 5.3.1; it is a re-release of 5.3.0 with the signing fix applied. Link to Devin session: https://app.devin.ai/sessions/226ed88b8e8a4434920f2d7e3a49ee61 Requested by: @kinyoklion <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Dependency-only version bumps with no functional or API changes in this repo. > > **Overview** > Bumps the **LaunchDarkly.EventSource** NuGet dependency to **5.3.1** in both SDK packages so consumers get Authenticode (DigiCert)–signed assemblies. **ServerSdk** moves from 5.3.0 → 5.3.1; **ClientSdk** from 5.2.1 → 5.3.1. > > There are no application code changes—only `PackageReference` version lines in `LaunchDarkly.ServerSdk.csproj` and `LaunchDarkly.ClientSdk.csproj`. 5.3.1 is a re-release of 5.3.0 with corrected publish/signing workflow. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 9979f2c. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
sign-dllsstep inpublish.ymlwas referencingLaunchDarkly.EventSource.Microsoft.dll, but the assembly is namedLaunchDarkly.EventSource(per the csprojAssemblyName), producingLaunchDarkly.EventSource.dll. The signing action was looking for the wrong DLL, so Authenticode signing was not applied.Link to Devin session: https://app.devin.ai/sessions/226ed88b8e8a4434920f2d7e3a49ee61
Requested by: @kinyoklion
Note
Low Risk
Single workflow input correction with no runtime or application logic changes.
Overview
The publish workflow’s Sign DLLs step now passes
LaunchDarkly.EventSource.dlltosign-dllsinstead ofLaunchDarkly.EventSource.Microsoft.dll, matching theAssemblyNamein the EventSource csproj.That mismatch meant the signing action never found the built assembly, so Authenticode signing was skipped on release builds.
Reviewed by Cursor Bugbot for commit dca5434. Bugbot is set up for automated code reviews on this repo. Configure here.