Skip to content

fix: fix dll_name for Authenticode signing in publish workflow#121

Merged
kinyoklion merged 1 commit into
mainfrom
devin/1782920626-fix-dll-signing-name
Jul 1, 2026
Merged

fix: fix dll_name for Authenticode signing in publish workflow#121
kinyoklion merged 1 commit into
mainfrom
devin/1782920626-fix-dll-signing-name

Conversation

@kinyoklion

@kinyoklion kinyoklion commented Jul 1, 2026

Copy link
Copy Markdown
Member

Summary

The sign-dlls step in publish.yml was referencing LaunchDarkly.EventSource.Microsoft.dll, but the assembly is named LaunchDarkly.EventSource (per the csproj AssemblyName), producing LaunchDarkly.EventSource.dll. The signing action was looking for the wrong DLL, so Authenticode signing was not applied.

- dll_name: LaunchDarkly.EventSource.Microsoft.dll
+ dll_name: LaunchDarkly.EventSource.dll

Link to Devin session: https://app.devin.ai/sessions/226ed88b8e8a4434920f2d7e3a49ee61
Requested by: @kinyoklion


Note

Low Risk
Single workflow input correction with no runtime or application logic changes.

Overview
The publish workflow’s Sign DLLs step now passes LaunchDarkly.EventSource.dll to sign-dlls instead of LaunchDarkly.EventSource.Microsoft.dll, matching the AssemblyName in the EventSource csproj.

That mismatch meant the signing action never found the built assembly, so Authenticode signing was skipped on release builds.

Reviewed by Cursor Bugbot for commit dca5434. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
@kinyoklion kinyoklion self-assigned this Jul 1, 2026
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot added the devin-pr PR created by Devin label Jul 1, 2026
@kinyoklion kinyoklion changed the title ci: fix dll_name for Authenticode signing in publish workflow fix: fix dll_name for Authenticode signing in publish workflow Jul 1, 2026
@kinyoklion kinyoklion added the devin-pr PR created by Devin label Jul 1, 2026
@kinyoklion kinyoklion marked this pull request as ready for review July 1, 2026 15:45
@kinyoklion kinyoklion requested a review from a team as a code owner July 1, 2026 15:45
@kinyoklion kinyoklion merged commit ac7c5a7 into main Jul 1, 2026
6 checks passed
@kinyoklion kinyoklion deleted the devin/1782920626-fix-dll-signing-name branch July 1, 2026 16:24
kinyoklion pushed a commit that referenced this pull request Jul 1, 2026
🤖 I have created a release *beep* *boop*
---


##
[5.3.1](5.3.0...5.3.1)
(2026-07-01)


### Bug Fixes

* fix dll_name for Authenticode signing in publish workflow
([#121](#121))
([ac7c5a7](ac7c5a7))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Version and documentation-only release; no application code changes in
this PR.
> 
> **Overview**
> This is an automated **5.3.1** patch release: version is updated in
`.release-please-manifest.json`, `LaunchDarkly.EventSource.csproj`,
`PROVENANCE.md`, and `CHANGELOG.md`.
> 
> There are **no library or runtime code changes** in this diff. The
release notes document the already-merged fix
([#121](#121))
that corrects `dll_name` for Authenticode signing in the publish
workflow (`LaunchDarkly.EventSource.dll` in
`.github/workflows/publish.yml`).
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
dcc3ba6. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
kinyoklion added a commit to launchdarkly/dotnet-core that referenced this pull request Jul 1, 2026
… assemblies (#303)

**Related issues**

- launchdarkly/dotnet-eventsource#121 — fixed
incorrect `dll_name` in the publish workflow that prevented Authenticode
signing

**Describe the solution you've provided**

Updates `LaunchDarkly.EventSource` from 5.3.0 → 5.3.1 in ServerSdk and
from 5.2.1 → 5.3.1 in ClientSdk. Version 5.3.1 is the first release with
correct Authenticode (DigiCert) signing — prior versions shipped
unsigned due to a typo in the publish workflow.

**Describe alternatives you've considered**

N/A — this is a dependency bump to pick up correctly signed assemblies.

**Additional context**

No functional changes in 5.3.1; it is a re-release of 5.3.0 with the
signing fix applied.

Link to Devin session:
https://app.devin.ai/sessions/226ed88b8e8a4434920f2d7e3a49ee61
Requested by: @kinyoklion

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Dependency-only version bumps with no functional or API changes in
this repo.
> 
> **Overview**
> Bumps the **LaunchDarkly.EventSource** NuGet dependency to **5.3.1**
in both SDK packages so consumers get Authenticode (DigiCert)–signed
assemblies. **ServerSdk** moves from 5.3.0 → 5.3.1; **ClientSdk** from
5.2.1 → 5.3.1.
> 
> There are no application code changes—only `PackageReference` version
lines in `LaunchDarkly.ServerSdk.csproj` and
`LaunchDarkly.ClientSdk.csproj`. 5.3.1 is a re-release of 5.3.0 with
corrected publish/signing workflow.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
9979f2c. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devin-pr PR created by Devin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants