Skip to content

fix: fail sign-dlls action when no matching DLLs are found#96

Open
kinyoklion wants to merge 1 commit into
mainfrom
devin/1782922858-sign-dlls-fail-on-missing
Open

fix: fail sign-dlls action when no matching DLLs are found#96
kinyoklion wants to merge 1 commit into
mainfrom
devin/1782922858-sign-dlls-fail-on-missing

Conversation

@kinyoklion

Copy link
Copy Markdown
Member

Summary

The sign-dlls action silently succeeds when dll_name doesn't match any files — the find returns nothing and the for loop body never executes. This allowed dotnet-eventsource to ship 3 releases without Authenticode signing due to a typo in the dll_name input (see launchdarkly/dotnet-eventsource#121).

Added a guard that checks find results before the loop and fails with ::error:: if no DLLs are found. All current callers provide correct names, so no existing workflows will break.

Link to Devin session: https://app.devin.ai/sessions/226ed88b8e8a4434920f2d7e3a49ee61
Requested by: @kinyoklion

Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
@kinyoklion kinyoklion self-assigned this Jul 1, 2026
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@kinyoklion kinyoklion marked this pull request as ready for review July 1, 2026 16:23
@kinyoklion kinyoklion requested a review from a team as a code owner July 1, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants