fix: fail sign-dlls action when no matching DLLs are found#96
Open
kinyoklion wants to merge 1 commit into
Open
fix: fail sign-dlls action when no matching DLLs are found#96kinyoklion wants to merge 1 commit into
kinyoklion wants to merge 1 commit into
Conversation
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
joker23
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
sign-dllsaction silently succeeds whendll_namedoesn't match any files — thefindreturns nothing and theforloop body never executes. This allowed dotnet-eventsource to ship 3 releases without Authenticode signing due to a typo in thedll_nameinput (see launchdarkly/dotnet-eventsource#121).Added a guard that checks
findresults before the loop and fails with::error::if no DLLs are found. All current callers provide correct names, so no existing workflows will break.Link to Devin session: https://app.devin.ai/sessions/226ed88b8e8a4434920f2d7e3a49ee61
Requested by: @kinyoklion