ci(go-ci): make dependency-review non-blocking#20
Merged
Conversation
The dependency-review action errors hard ('not supported on this
repository') when a repo's Dependency Graph isn't available — which blocks
adoption of the shared workflow on newer/restricted repos. nox's OSV check
is the org's gating dependency-CVE source of truth; dependency-review is
supplementary, so mark it continue-on-error: report where the graph exists,
skip (not fail) where it doesn't.
There was a problem hiding this comment.
Pull request overview
This PR updates the shared Go CI workflow to ensure the Dependency Review job doesn’t block PRs on repositories where GitHub’s Dependency Graph (and therefore dependency-review) isn’t supported, aligning with the org’s primary gating CVE signal coming from the nox OSV scan.
Changes:
- Marks the
dependency-reviewjob as non-blocking viacontinue-on-error: true. - Adds inline documentation explaining why dependency-review is supplementary and why failures shouldn’t block adoption.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+198
to
201
| continue-on-error: true | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| - uses: actions/dependency-review-action@a1d282b36b6f3519aa1f3fc636f609c47dddb294 # v5.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
dependency-reviewaction fails hard with "Dependency review is not supported on this repository" when a repo's Dependency Graph isn't available — blocking adoption of the shared workflow on newer/org-restricted repos (hit while rolling go-ci out to the rollops-plugin repos).nox's OSV scan (Security job) is the org's gating dependency-CVE source of truth, so dependency-review is supplementary. Marking it
continue-on-error: truekeeps the GitHub advisory view where the graph exists and skips (not fails) where it doesn't. No caller changes.