ci(go-ci): drop dependency-review job (nox OSV owns dep CVEs)#21
Merged
Conversation
dependency-review duplicated nox's OSV scan, which the org designates as
the single dependency-CVE source of truth (golangci.reference.yml security
note). It also errors hard ('not supported on this repository') on repos
without a Dependency Graph, blocking adoption of this workflow. Remove it;
one fewer billable job per PR and dep-CVE gating stays with nox.
There was a problem hiding this comment.
Pull request overview
Removes the dependency-review job from the reusable Go CI workflow to avoid redundant dependency-CVE scanning (owned org-wide by the nox OSV scan) and to prevent hard failures in repositories without GitHub Dependency Graph support.
Changes:
- Deleted the
dependency-reviewjob from.github/workflows/go-ci.yml. - Added an inline note documenting why dependency-CVE gating is routed exclusively through nox.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes the
continue-on-errorband-aid (#20). Removes the GitHubdependency-reviewjob from the reusable:golangci.reference.yml's security note already states nox owns deps. dependency-review was a second, overlapping tool.Dependency-CVE gating stays with nox. No caller changes.