Fix Arabic countdown rendering regression in embeddable banner#166
Merged
marcprux merged 3 commits intokeepandroidopen:mainfrom Mar 2, 2026
Merged
Fix Arabic countdown rendering regression in embeddable banner#166marcprux merged 3 commits intokeepandroidopen:mainfrom
marcprux merged 3 commits intokeepandroidopen:mainfrom
Conversation
…mmarize-findings Use Intl.NumberFormat unit style for countdown localization
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: I CREATED THIS PR USING OPENAI'S CODEX BECAUSE I'M A BEGINNER IN PROGRAMMING.
Summary
This PR addresses a regression introduced in the countdown localization refactor for the embeddable banner script.
Problem
After switching countdown unit rendering to Intl.NumberFormat unit formatting, Arabic users reported incorrect countdown behavior (appearing to loop/reset every hour instead of progressing normally). The issue manifests specifically in Arabic locale rendering and unit composition in the banner countdown output.
Scope
Revisit the recent countdown localization changes in public/banner.js.
Ensure Arabic countdown output is stable, monotonic, and consistent with English behavior.
Keep localization support intact for all supported locales.
Acceptance Criteria
Arabic countdown decrements correctly across seconds/minutes/hours/days without reset-like behavior.
English countdown remains unchanged and correct.
No regressions in embeddable banner parameters (lang, size, id, link, hidebutton).
Validation
Manual verification on /ar/ and / (English) pages.
Confirm countdown continuity over multiple minute/hour boundaries.
Confirm no functional changes to banner injection, dismissal, or timer lifecycle.
Notes
This PR is focused only on countdown rendering correctness and does not alter the broader banner UX/API.
Attached is a screenshot showing the timer correctly synchronized with the September 2026 deadline in the Arabic locale: