Skip to content

Small fixes for Dutch#185

Merged
marcprux merged 1 commit intokeepandroidopen:mainfrom
ltguillaume:main
Mar 1, 2026
Merged

Small fixes for Dutch#185
marcprux merged 1 commit intokeepandroidopen:mainfrom
ltguillaume:main

Conversation

@ltguillaume
Copy link
Contributor

It seems that the (English) banner.js string used to have "in" at the end, but not anymore.

This commit should fix that for Dutch, but some other translations still have "in" (translated) at the end, causing the end results be something like "Android will become a locked-down platform in in 183d 7h 25m 54s".

@marcprux
Copy link
Collaborator

marcprux commented Mar 1, 2026

Thanks! Hopefully others can help fix the double "in". I'm not sure why that was ever the case (the English version has always been "Android will become a locked-down platform" with a trailing "in").

@marcprux marcprux merged commit d2e6d23 into keepandroidopen:main Mar 1, 2026
2 checks passed
@marcprux
Copy link
Collaborator

marcprux commented Mar 2, 2026

We actually reconsidered this in #166 and put the "in" back at the end of the English at 2356a78, so we might want to revert this. If you have a chance to take a look at the current Dutch and confirm that it now looks odd again, let us know (or submit a new PR adding back the trailing "in"…)

@ltguillaume
Copy link
Contributor Author

ltguillaume commented Mar 2, 2026

I see.

  • I'll do a new PR to fix it for Dutch ✓
  • Other languages are now missing the (translated) "in", such as German, Spanish and French

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants