Skip to content

Return empty search result when providers return no jobs (remove mock example jobs) #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joelnishanth merged 1 commit into from
May 5, 2026
Merged

Return empty search result when providers return no jobs (remove mock example jobs) #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 8 additions & 83 deletions apps/extension-chrome/src/shared/job-search-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,14 @@ export async function searchJobs(filters: JobSearchFilters): Promise<JobSearchRe
const allJobs = deduplicateJobs(locationFiltered);

if (allJobs.length === 0) {
return generateMockResults(filters);
const emptyResult: JobSearchResult = {
jobs: [],
totalResults: 0,
page: filters.page ?? 1,
totalPages: 0,
};
cache.set(cacheKey, { data: emptyResult, ts: Date.now() });
return emptyResult;
}

const result: JobSearchResult = {
Expand All @@ -257,88 +264,6 @@ export async function searchJobs(filters: JobSearchFilters): Promise<JobSearchRe
return result;
}

function generateMockResults(filters: JobSearchFilters): JobSearchResult {
const mockJobs: JobListing[] = [
{
id: 'mock_1',
title: `Senior ${filters.keywords || 'Software'} Engineer`,
company: 'TechCorp Inc.',
location: filters.location || 'San Francisco, CA',
description: `We are looking for an experienced ${filters.keywords || 'software'} engineer to join our team. You will work on building scalable systems and leading technical initiatives.`,
salaryMin: 120000,
salaryMax: 180000,
salaryCurrency: 'USD',
url: 'https://example.com/job/1',
postedDate: new Date(Date.now() - 86400000).toISOString(),
source: 'mock',
category: 'IT Jobs',
},
{
id: 'mock_2',
title: `${filters.keywords || 'Software'} Developer`,
company: 'StartupAI',
location: filters.location || 'New York, NY',
description: `Join our fast-growing startup as a ${filters.keywords || 'software'} developer. Work with cutting-edge AI technologies.`,
salaryMin: 90000,
salaryMax: 140000,
salaryCurrency: 'USD',
url: 'https://example.com/job/2',
postedDate: new Date(Date.now() - 172800000).toISOString(),
source: 'mock',
category: 'IT Jobs',
},
{
id: 'mock_3',
title: `Lead ${filters.keywords || 'Software'} Architect`,
company: 'Enterprise Solutions Ltd',
location: filters.location || 'Remote',
description: `Design and implement enterprise-scale ${filters.keywords || 'software'} systems. Lead a team of 8 engineers.`,
salaryMin: 150000,
salaryMax: 220000,
salaryCurrency: 'USD',
url: 'https://example.com/job/3',
postedDate: new Date(Date.now() - 259200000).toISOString(),
source: 'mock',
category: 'IT Jobs',
},
{
id: 'mock_4',
title: `Junior ${filters.keywords || 'Software'} Engineer`,
company: 'DevHub',
location: filters.location || 'Austin, TX',
description: `Great opportunity for a junior ${filters.keywords || 'software'} engineer. Mentorship program and growth path included.`,
salaryMin: 70000,
salaryMax: 100000,
salaryCurrency: 'USD',
url: 'https://example.com/job/4',
postedDate: new Date(Date.now() - 345600000).toISOString(),
source: 'mock',
category: 'IT Jobs',
},
{
id: 'mock_5',
title: `${filters.keywords || 'Software'} Engineering Manager`,
company: 'GlobalTech',
location: filters.location || 'Seattle, WA',
description: `Manage a distributed team building ${filters.keywords || 'software'} products used by millions.`,
salaryMin: 160000,
salaryMax: 230000,
salaryCurrency: 'USD',
url: 'https://example.com/job/5',
postedDate: new Date(Date.now() - 432000000).toISOString(),
source: 'mock',
category: 'IT Jobs',
},
];

return {
jobs: mockJobs,
totalResults: mockJobs.length,
page: 1,
totalPages: 1,
};
}

export function computeCompatibilityScore(
job: JobListing,
profileSkills: string[],
Expand Down
91 changes: 8 additions & 83 deletions apps/extension-firefox/src/shared/job-search-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,14 @@ export async function searchJobs(filters: JobSearchFilters): Promise<JobSearchRe
const allJobs = deduplicateJobs(locationFiltered);

if (allJobs.length === 0) {
return generateMockResults(filters);
const emptyResult: JobSearchResult = {
jobs: [],
totalResults: 0,
page: filters.page ?? 1,
totalPages: 0,
};
cache.set(cacheKey, { data: emptyResult, ts: Date.now() });
return emptyResult;
}

const result: JobSearchResult = {
Expand All @@ -257,88 +264,6 @@ export async function searchJobs(filters: JobSearchFilters): Promise<JobSearchRe
return result;
}

function generateMockResults(filters: JobSearchFilters): JobSearchResult {
const mockJobs: JobListing[] = [
{
id: 'mock_1',
title: `Senior ${filters.keywords || 'Software'} Engineer`,
company: 'TechCorp Inc.',
location: filters.location || 'San Francisco, CA',
description: `We are looking for an experienced ${filters.keywords || 'software'} engineer to join our team. You will work on building scalable systems and leading technical initiatives.`,
salaryMin: 120000,
salaryMax: 180000,
salaryCurrency: 'USD',
url: 'https://example.com/job/1',
postedDate: new Date(Date.now() - 86400000).toISOString(),
source: 'mock',
category: 'IT Jobs',
},
{
id: 'mock_2',
title: `${filters.keywords || 'Software'} Developer`,
company: 'StartupAI',
location: filters.location || 'New York, NY',
description: `Join our fast-growing startup as a ${filters.keywords || 'software'} developer. Work with cutting-edge AI technologies.`,
salaryMin: 90000,
salaryMax: 140000,
salaryCurrency: 'USD',
url: 'https://example.com/job/2',
postedDate: new Date(Date.now() - 172800000).toISOString(),
source: 'mock',
category: 'IT Jobs',
},
{
id: 'mock_3',
title: `Lead ${filters.keywords || 'Software'} Architect`,
company: 'Enterprise Solutions Ltd',
location: filters.location || 'Remote',
description: `Design and implement enterprise-scale ${filters.keywords || 'software'} systems. Lead a team of 8 engineers.`,
salaryMin: 150000,
salaryMax: 220000,
salaryCurrency: 'USD',
url: 'https://example.com/job/3',
postedDate: new Date(Date.now() - 259200000).toISOString(),
source: 'mock',
category: 'IT Jobs',
},
{
id: 'mock_4',
title: `Junior ${filters.keywords || 'Software'} Engineer`,
company: 'DevHub',
location: filters.location || 'Austin, TX',
description: `Great opportunity for a junior ${filters.keywords || 'software'} engineer. Mentorship program and growth path included.`,
salaryMin: 70000,
salaryMax: 100000,
salaryCurrency: 'USD',
url: 'https://example.com/job/4',
postedDate: new Date(Date.now() - 345600000).toISOString(),
source: 'mock',
category: 'IT Jobs',
},
{
id: 'mock_5',
title: `${filters.keywords || 'Software'} Engineering Manager`,
company: 'GlobalTech',
location: filters.location || 'Seattle, WA',
description: `Manage a distributed team building ${filters.keywords || 'software'} products used by millions.`,
salaryMin: 160000,
salaryMax: 230000,
salaryCurrency: 'USD',
url: 'https://example.com/job/5',
postedDate: new Date(Date.now() - 432000000).toISOString(),
source: 'mock',
category: 'IT Jobs',
},
];

return {
jobs: mockJobs,
totalResults: mockJobs.length,
page: 1,
totalPages: 1,
};
}

export function computeCompatibilityScore(
job: JobListing,
profileSkills: string[],
Expand Down
Loading