Return empty search result when providers return no jobs (remove mock example jobs)#7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
https://example.com/...when clicking Apply because the search service generated mock jobs with example URLs when all providers returned no results.Description
generateMockResultsfallback and related mock job data from bothapps/extension-chrome/src/shared/job-search-service.tsandapps/extension-firefox/src/shared/job-search-service.ts.searchJobsto return an explicit emptyJobSearchResult(jobs: [],totalResults: 0,page: filters.page ?? 1,totalPages: 0) and cache that empty result when upstream providers yield no jobs.Testing
rg -n "generateMockResults|example.com/job", confirming removal of mock entries.apps/extension-chrome/src/shared/job-search-service.tsandapps/extension-firefox/src/shared/job-search-service.ts).npm --prefix apps/extension-chrome run -s test -- src/popup/popup.test.ts, but the test runner failed in this environment becausevitestis not available, so unit tests were not executed here.Codex Task