Optional background images for job statuses

[smurf667]

Hello, this feature allows to show an optional and configurable background image per job status.

[jenkinsadmin]

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

[batmat]

Why that? Are you trying to prevent autoboxing or something?

[smurf667]

Yes, I am. This is just a matter of preference - I'm no fan of autoboxing...

[batmat]

Well, I just feel this is a bit more verbose in that case. Anyway :).

Back to the very goal of that PR itself, please revert those changes as they're unrelated to the newly introduced feature, so that the code change only contains the part related to the addition.

If you really wish to replace those, please file another dedicated PR.

Thanks!

[batmat]

Hi @smurf667, thanks for your work!

As is, and also because the existing code was not already perfect in the regard, I would be reluctant to add and manage again more scalar attributes.

I think the existinig code and the PR should/could be reworked to avoid adding and conveying yet again 5 more attributes/parameters.

Thanks again!

[batmat]

whitespace modification

[batmat]

Hi @smurf667 I've committed 14403e5 that uses @DataBoundSetter to avoid having a bunch of parameters in the constructor.

Could you please:

• rebase on the master tip and use the same principle to use the same "pattern"?
• squash your multiple commits this PR so that commits are more meaningful (basically, squash/fixup any commit whose role is only to fix a previous one of the PR)

Then I'll have a look again.

(I'd still like to improve the code to use richer objects and aggregate related things, but that an issue outside the scope of your PR so I'll do that later if I ever find the time to do it.)

[smurf667]

Hi,
I've adapted the code, but my Git-foo is not sufficient for the squashing. The commits appear meaningful to me anyway. Hope that is good enough. Otherwise I'll close the pull request as I can't spend more time on this. Thanks!