Skip to content

added user configuration of Project separator char#17

Closed
szandala wants to merge 1 commit into
jenkinsci:masterfrom
szandala:master
Closed

added user configuration of Project separator char#17
szandala wants to merge 1 commit into
jenkinsci:masterfrom
szandala:master

Conversation

@szandala

Copy link
Copy Markdown

I was asked by my company to add option in which user can define his own project separator mark.
Please consider it's usefullness.
Regards,
szandala

@jenkinsadmin

Copy link
Copy Markdown
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@batmat batmat changed the title added user configuration of Project separatpr char added user configuration of Project separator char Jan 22, 2016
Comment thread pom.xml

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That change makes that PR unmergeable as-is anyway @szandala

@batmat

batmat commented Jan 22, 2016

Copy link
Copy Markdown
Member

@szandala Thanks for the work! Sorry for coming so late.

After looking at the code, IMO this PR needs to be reworked to include at least multiple separator chars to be backward compatible.

Thanks

@batmat

batmat commented Feb 12, 2016

Copy link
Copy Markdown
Member

Hi, first: sorry for the delay.

If you can please:

I think I'll leave this PR open until the end of february or about. If nothing happened in the meantime, then I think I'll close that PR.

Important note: please feel absolutely free to reopen in this case if you find time to handle it later. I just plan to do it to keep the PR list manageable and in a better state than what I've been able to do until now. I'd understand you answer this later and reopen perfectly, since this is somehow what I've been doing here many times.

Thank you

batmat added a commit that referenced this pull request Feb 15, 2016
Goal: be able to use DataBoundSetter to try and clean the currently
bloated constructor (and many PR still open wanting to open yet many
other new attributes :-/).

See https://groups.google.com/forum/#!topic/jenkinsci-dev/58-DEvuJZWI :
this new feature requires 1.535 (so choosing the next LTS above that).

See also:
* #18
* #17
@batmat

batmat commented Feb 20, 2016

Copy link
Copy Markdown
Member

Closing as per my last comment.

@batmat batmat closed this Feb 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants