fix(brief): skip self-intersecting polygons in coverage checks (#11)

lib/skywatch/brief/analysis/adverse_filter.rb

@@ -9,6 +9,8 @@ def self.covers?(product, lat, lon)
           return false if polygon.nil?
 
           polygon.contains?(Skywatch::Shared::Geometry.point(lat, lon))
+        rescue RGeo::Error::InvalidGeometry
+          false
         end
 
         def self.within(items, lat:, lon:, radius_nm:)

lib/skywatch/nimbus/models/outlook.rb

@@ -70,6 +70,8 @@ def covers?(lat:, lon:)
           return false if geometry.nil?
 
           geometry.contains?(FACTORY.point(lon, lat))
+        rescue RGeo::Error::InvalidGeometry
+          false
         end
 
         def to_h # rubocop:disable Metrics/MethodLength

spec/brief/analysis/adverse_filter_spec.rb

@@ -27,6 +27,19 @@
       degenerate = Skywatch::Briefer::Models::Sigmet.new(coords: [])
       expect(described_class.covers?(degenerate, 40.875, -74.282)).to be false
     end
+
+    it 'returns false when the polygon is self-intersecting (RGeo InvalidGeometry)' do
+      # Bowtie ring: edges cross — RGeo raises Self-intersection on contains?
+      bowtie = Skywatch::Briefer::Models::Sigmet.new(coords: [
+                                                       Skywatch::Shared::Position.new(lat: 40.0, lon: -74.0),
+                                                       Skywatch::Shared::Position.new(lat: 41.0, lon: -73.0),
+                                                       Skywatch::Shared::Position.new(lat: 40.0, lon: -73.0),
+                                                       Skywatch::Shared::Position.new(lat: 41.0, lon: -74.0),
+                                                       Skywatch::Shared::Position.new(lat: 40.0, lon: -74.0)
+                                                     ])
+      expect { described_class.covers?(bowtie, 40.5, -73.5) }.not_to raise_error
+      expect(described_class.covers?(bowtie, 40.5, -73.5)).to be false
+    end
   end
 
   describe '.within' do

spec/nimbus/models/outlook_spec.rb

@@ -93,6 +93,20 @@
       expect(mrgl.covers?(lat: 41.4, lon: -74.9)).to be(true)
       expect(slgt.covers?(lat: 41.4, lon: -74.9)).to be(false)
     end
+
+    it 'returns false when the geometry is self-intersecting (RGeo InvalidGeometry)' do
+      factory = described_class::FACTORY
+      bowtie_ring = factory.linear_ring([
+                                          factory.point(-74.0, 40.0),
+                                          factory.point(-73.0, 41.0),
+                                          factory.point(-73.0, 40.0),
+                                          factory.point(-74.0, 41.0),
+                                          factory.point(-74.0, 40.0)
+                                        ])
+      bad = described_class.new(**attrs, geometry: factory.polygon(bowtie_ring))
+      expect { bad.covers?(lat: 40.5, lon: -73.5) }.not_to raise_error
+      expect(bad.covers?(lat: 40.5, lon: -73.5)).to be(false)
+    end
   end
 
   describe '#to_h' do