fix(brief): skip self-intersecting polygons in coverage checks (#11)#17
Merged
Conversation
AIRMET (and any source returning hand-drawn polygons) can produce self-intersecting rings that pass construction but raise RGeo::Error::InvalidGeometry on contains?. The error surfaced in every Skywatch.brief call as a partial_failures entry for the whole AIRMET source. Rescue InvalidGeometry per-product in the two .contains? call sites (AdverseFilter.covers? and Outlook#covers?), returning false. Bad polygons are skipped silently; the rest of the source continues. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RGeo::Error::InvalidGeometryper-product in the two.contains?call sites —AdverseFilter.covers?(AIRMET/SIGMET/TFR) andOutlook#covers?(Nimbus SPC outlooks). Bad polygons are skipped silently; the rest of the source continues.contains?. Before this fix, a single bad AIRMET surfaced as a partial failure for the entire AIRMET source on everyskywatch briefcall.Closes #11.
Test plan
AdverseFilter.covers?with a bowtie-ring SIGMET — does not raise, returns falseOutlook#covers?with a bowtie-ring geometry — does not raise, returns falsebundle exec rspec— 447 examples, 0 failuresbundle exec rubocop— clean🤖 Generated with Claude Code