quality: adopt canonical check:all standard (pl-a59c)#7
Merged
Conversation
Adopt the os-eco fleet check:all standard (docs/check-all-standard.md at the meta-repo root, rev 1): - Copy the byte-identical quiet runner scripts/check-all.ts and parity detector scripts/check-ci-parity.ts (plus their test suites) from templates/l5-toolkit; verified with cmp against the template. - Replace the 5-gate && chain with "check:all": "bun scripts/check-all.ts" and add the "verify" alias. The resolved manifest is now 10 gates: lint, typecheck, check:agents, check:dups, check:deps, check:size, check:debt, gen:docs:check (conditional, auto-detected), check:coverage, check:ci-parity — coverage and the docs-drift gate join the gate set. - Add check:ci-parity script + yaml devDependency; per-repo escape hatches in scripts/ci-parity-config.json (test:ci aliased to check:coverage for the junit reporter, report:* steps ciOnly). - Reconcile ci.yml: standalone lint/typecheck/gen:docs:check/ check:coverage steps collapse into "bun run check:all"; test:ci kept for the junit/coverage artifacts. - Add co-located test suites for check-file-sizes.ts and check-debt-markers.ts from the toolkit (lint-formatted). - biome: disable the formatter for the two byte-identical scripts (fleet pattern), bump @biomejs/biome to the fleet baseline (^2.4.14). - AGENTS.md: document the 10-gate manifest, verify entry point, and CI parity contract. Closes canopy-3b09, canopy-b9ee, canopy-e548 (plan pl-a59c). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adopts the frozen os-eco fleet
check:allstandard (os-ecodocs/check-all-standard.md, rev 1) — seeds plan pl-a59c, children canopy-3b09 / canopy-b9ee / canopy-e548.canopy-3b09):scripts/check-all.ts+check-all.test.tscopied byte-identical fromtemplates/l5-toolkit;"check:all": "bun scripts/check-all.ts"replaces the old 5-gate&&chain, and"verify": "bun run check:all"is the agent-facing alias. The resolved manifest is 10 gates —check:coverageandgen:docs:check(auto-detected conditional gate) join the gate set. Also adds the toolkit's co-located test suites forcheck-file-sizes.ts/check-debt-markers.ts.canopy-b9ee):scripts/check-ci-parity.ts+ test copied byte-identical;check:ci-parityscript andyamldevDependency added. Gate names were already canonical (terse) in canopy.canopy-e548): standalone Lint / Typecheck / gen:docs:check / Coverage-ratchet steps inci.ymlcollapse into a singlebun run check:allstep;test:cistays for the junit + coverage artifacts. Justified escape hatches live inscripts/ci-parity-config.json:test:ci → check:coveragealias (same gate, junit reporter) andreport:test-timing/report:quality-metricsasciOnlysummaries.Supporting changes:
biome.json: formatter disabled for the two byte-identical scripts (same override pattern as plot/seeds — the frozen files may not be reformatted);@biomejs/biomebumped from ^2.4.6 to the fleet baseline (^2.4.14, resolves 2.4.16) with matching$schema.AGENTS.md: quality-gates docs now describe the 10-gate manifest,verify, and the CI-parity contract (per-change verification is nowbun run verify).Acceptance verification
bun run check:all→10/10 gates passed (14.1s)✅bun run verify→10/10 gates passed (13.6s)✅cmp scripts/check-all.ts ../templates/l5-toolkit/scripts/check-all.tsandcmp scripts/check-ci-parity.ts ../templates/l5-toolkit/scripts/check-ci-parity.ts→ clean (byte-identical) ✅bun run check:ci-parity→✓ CI parity: 4 bun-run invocation(s) across CI workflows, all reachable from "check:all" (12 scripts in graph).✅gen:docs:checkandcheck:coveragewere already green when joining the manifest (coverage 75.97% fn / 72.34% lines vs floors 75/72); no underlying fixes needed.🤖 Generated with Claude Code