fix(teams): label autologin dropdown rows [C]/[A] to match pills#11
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesAutologin Teams Dropdown Label Prefixes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Jun 4, 2026
itsnateai
added a commit
that referenced
this pull request
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In the Autologin Teams dialog, the slot dropdowns prefixed each row with an emoji — 🧙 for Characters, 🔑 for Accounts. But the status pills beside each dropdown and the legend below speak in C / A ("C = Character, A = Account"). So while choosing an entry the user had to guess what the wizard/key glyphs meant; the matching C/A pill only appeared after selecting.
This swaps the emoji for
[C]/[A]tags so the closed box and every dropdown row use the dialog's own C/A vocabulary.Change
One method,
AutoLoginTeamsDialog.BuildComboItems():🧙 {Name}→[C] {Name}(Characters)🔑 {Username}→[A] {Username}(Accounts)Why it's safe
Value(char:Name/acct:NameviaQuickLoginSlot.ForCharacter/ForAccount) is untouched. Nothing about save, load, or team dispatch changes.QuickLoginSlotTests/TeamSlotResolverTestsassert onValue, never the display string.DrawComboItem— the bracketed letter reads as a tag the way the colored pill badge does.Scope
Deliberately Teams-only and surgical so it can merge anytime. The sibling
QuickLoginSlotsDialogalso uses 🧙/🔑, but it has its own emoji legend so it is internally consistent — left untouched. Easy to align in a follow-up if desired.Summary by CodeRabbit
[C]prefix and Account options now show[A]prefix instead of previous emoji icons.