Skip to content

fix(teams): label autologin dropdown rows [C]/[A] to match pills#11

Merged
itsnateai merged 1 commit into
mainfrom
fix/teams-dropdown-ca-labels
Jun 5, 2026
Merged

fix(teams): label autologin dropdown rows [C]/[A] to match pills#11
itsnateai merged 1 commit into
mainfrom
fix/teams-dropdown-ca-labels

Conversation

@itsnateai
Copy link
Copy Markdown
Owner

@itsnateai itsnateai commented Jun 4, 2026

What

In the Autologin Teams dialog, the slot dropdowns prefixed each row with an emoji — 🧙 for Characters, 🔑 for Accounts. But the status pills beside each dropdown and the legend below speak in C / A ("C = Character, A = Account"). So while choosing an entry the user had to guess what the wizard/key glyphs meant; the matching C/A pill only appeared after selecting.

This swaps the emoji for [C] / [A] tags so the closed box and every dropdown row use the dialog's own C/A vocabulary.

Change

One method, AutoLoginTeamsDialog.BuildComboItems():

  • 🧙 {Name}[C] {Name} (Characters)
  • 🔑 {Username}[A] {Username} (Accounts)

Why it's safe

  • Display-only. The persisted/resolved Value (char:Name / acct:Name via QuickLoginSlot.ForCharacter/ForAccount) is untouched. Nothing about save, load, or team dispatch changes.
  • No test impact. QuickLoginSlotTests / TeamSlotResolverTests assert on Value, never the display string.
  • Rows stay color-coded (Character blue, Account orange) via DrawComboItem — the bracketed letter reads as a tag the way the colored pill badge does.
  • Build clean (Debug, 0 warnings / 0 errors).

Scope

Deliberately Teams-only and surgical so it can merge anytime. The sibling QuickLoginSlotsDialog also uses 🧙/🔑, but it has its own emoji legend so it is internally consistent — left untouched. Easy to align in a follow-up if desired.

Summary by CodeRabbit

  • Style
    • Updated the Auto-Login Teams dropdown display: Character options now show [C] prefix and Account options now show [A] prefix instead of previous emoji icons.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 4, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 47601877-e6bb-4015-9e41-4e28d6dfd84d

📥 Commits

Reviewing files that changed from the base of the PR and between 04e0675 and c59b964.

📒 Files selected for processing (1)
  • UI/AutoLoginTeamsDialog.cs

📝 Walkthrough

Walkthrough

The BuildComboItems() method in AutoLoginTeamsDialog now displays character and account dropdown options with text prefixes [C] and [A] instead of emoji glyphs. The underlying option values and slot kind logic are unchanged.

Changes

Autologin Teams Dropdown Label Prefixes

Layer / File(s) Summary
Dropdown display prefixes
UI/AutoLoginTeamsDialog.cs
Character slot options now display [C] prefix and account options display [A] prefix in place of previous emoji glyphs (🧙 and 🔑). Option values and slot kinds unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: replacing emoji prefixes (🧙/🔑) with bracketed letters ([C]/[A]) in the autologin dropdown to match the pill labels.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/teams-dropdown-ca-labels

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@itsnateai itsnateai merged commit 8d79e97 into main Jun 5, 2026
4 checks passed
@itsnateai itsnateai deleted the fix/teams-dropdown-ca-labels branch June 5, 2026 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant