fix(quicklogin): label dropdown rows + legend [C]/[A] to match teams#12
Conversation
|
Warning Review limit reached
More reviews will be available in 5 minutes and 31 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What
Follow-up to #11 (Autologin Teams). The Quick Login Slots dialog (the four Auto-Login tray-click slots, opened from the Characters card) also prefixed dropdown rows with 🧙/🔑 emoji — and its legend was emoji too. This aligns it with the C/A vocabulary used everywhere else.
Change — one file,
QuickLoginSlotsDialog.cs🧙 {Name}→[C] {Name},🔑 {Username}→[A] {Username}🧙 Character → enters world 🔑 Account → char-select→[C] Character → enters world [A] Account → char-selectWhy it matters more here than in Teams
This dialog has no status pills (Teams has the blue-C / orange-A badges). So before this, the only textual kind cue was the emoji glyph plus row color — there were no C/A letters anywhere. Now the tag spells out the kind, matching what the Teams dialog and the rest of the app already say.
Why it's safe
Value(char:/acct:viaQuickLoginSlot.ForCharacter/ForAccount) is untouched.QuickLoginSlotTests/TeamSlotResolverTestsassert onValue.Display) and theIsSeparatorbounce logic are unchanged.DrawComboItem) and measure-to-fit width/legend sizing are string-agnostic — they self-adjust to the shorter[C]/[A]labels.Relationship to #11
Independent branch off
main, separately mergeable. Merge order doesn't matter — the two PRs touch different files (AutoLoginTeamsDialog.csvsQuickLoginSlotsDialog.cs) with no overlap.