Skip to content

fix(quicklogin): label dropdown rows + legend [C]/[A] to match teams#12

Merged
itsnateai merged 2 commits into
mainfrom
fix/quicklogin-dropdown-ca-labels
Jun 5, 2026
Merged

fix(quicklogin): label dropdown rows + legend [C]/[A] to match teams#12
itsnateai merged 2 commits into
mainfrom
fix/quicklogin-dropdown-ca-labels

Conversation

@itsnateai
Copy link
Copy Markdown
Owner

What

Follow-up to #11 (Autologin Teams). The Quick Login Slots dialog (the four Auto-Login tray-click slots, opened from the Characters card) also prefixed dropdown rows with 🧙/🔑 emoji — and its legend was emoji too. This aligns it with the C/A vocabulary used everywhere else.

Change — one file, QuickLoginSlotsDialog.cs

  • Dropdown items: 🧙 {Name}[C] {Name}, 🔑 {Username}[A] {Username}
  • Legend: 🧙 Character → enters world 🔑 Account → char-select[C] Character → enters world [A] Account → char-select
  • Two doc-comments updated so they don't contradict the code

Why it matters more here than in Teams

This dialog has no status pills (Teams has the blue-C / orange-A badges). So before this, the only textual kind cue was the emoji glyph plus row color — there were no C/A letters anywhere. Now the tag spells out the kind, matching what the Teams dialog and the rest of the app already say.

Why it's safe

  • Display-only. Persisted/dispatched Value (char: / acct: via QuickLoginSlot.ForCharacter/ForAccount) is untouched.
  • No test depends on the display stringQuickLoginSlotTests / TeamSlotResolverTests assert on Value.
  • The non-selectable separator row (empty Display) and the IsSeparator bounce logic are unchanged.
  • Owner-draw render (DrawComboItem) and measure-to-fit width/legend sizing are string-agnostic — they self-adjust to the shorter [C]/[A] labels.
  • Build clean (Debug, 0 warnings / 0 errors).

Relationship to #11

Independent branch off main, separately mergeable. Merge order doesn't matter — the two PRs touch different files (AutoLoginTeamsDialog.cs vs QuickLoginSlotsDialog.cs) with no overlap.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 4, 2026

Warning

Review limit reached

@itsnateai, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 5 minutes and 31 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7edc50c0-0076-4a95-b4b9-a0d608656e3e

📥 Commits

Reviewing files that changed from the base of the PR and between 04e0675 and aac5755.

📒 Files selected for processing (1)
  • UI/QuickLoginSlotsDialog.cs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/quicklogin-dropdown-ca-labels

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@itsnateai itsnateai merged commit 55276ec into main Jun 5, 2026
4 checks passed
@itsnateai itsnateai deleted the fix/quicklogin-dropdown-ca-labels branch June 5, 2026 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant