Merged
Conversation
Record real Upbit API responses as VCR cassettes and add structural validation tests for all 11 quotation endpoints. Closes #37 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
interruping
force-pushed
the
feat/vcr-quotation-cassettes
branch
from
ff8f384 to
f552241
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/conftest.py에upbeat_vcrVCR 인스턴스 설정 추가 (기본record_mode=none,VCR_RECORD_MODE환경변수로 전환)tests/api/test_quotation_vcr.py)tests/cassettes/quotation/*.yaml)Test plan
uv run pytest tests/api/test_quotation_vcr.py -v— VCR 리플레이 모드 11/11 passeduv run pytest tests/api/test_quotation.py -v— 기존 MockTransport 테스트 23/23 passeduv run ruff check— lint 통과Closes #37
🤖 Generated with Claude Code