Skip to content

Run thread-heavy integration tests in serial #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ludfjig wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Run thread-heavy integration tests in serial #1216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions Justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,9 +228,7 @@ test-integration guest target=default-target features="":
{{if os() == "windows" { "$env:" } else { "" } }}GUEST="{{guest}}"{{if os() == "windows" { ";" } else { "" } }} {{ cargo-cmd }} test --profile={{ if target == "debug" { "dev" } else { target } }} {{ target-triple-flag }} --test integration_test execute_on_heap {{ if features =="" {""} else {"--features " + features} }} -- --ignored

@# run the rest of the integration tests
@# skip interrupt_random_kill_stress_test and then run it explicitly so we can see the output more
{{if os() == "windows" { "$env:" } else { "" } }}GUEST="{{guest}}"{{if os() == "windows" { ";" } else { "" } }} {{ cargo-cmd }} test -p hyperlight-host {{ if features =="" {''} else if features=="no-default-features" {"--no-default-features" } else {"--no-default-features -F init-paging," + features } }} --profile={{ if target == "debug" { "dev" } else { target } }} {{ target-triple-flag }} --test '*' -- --skip interrupt_random_kill_stress_test
{{if os() == "windows" { "$env:" } else { "" } }}GUEST="{{guest}}"{{if os() == "windows" { ";" } else { "" } }} {{ cargo-cmd }} test -p hyperlight-host {{ if features =="" {''} else if features=="no-default-features" {"--no-default-features" } else {"--no-default-features -F init-paging," + features } }} --profile={{ if target == "debug" { "dev" } else { target } }} {{ target-triple-flag }} --test integration_test interrupt_random_kill_stress_test -- --nocapture --exact
{{if os() == "windows" { "$env:" } else { "" } }}GUEST="{{guest}}"{{if os() == "windows" { ";" } else { "" } }} {{ cargo-cmd }} test -p hyperlight-host {{ if features =="" {''} else if features=="no-default-features" {"--no-default-features" } else {"--no-default-features -F init-paging," + features } }} --profile={{ if target == "debug" { "dev" } else { target } }} {{ target-triple-flag }} --test '*'

# tests compilation with no default features on different platforms
test-compilation-no-default-features target=default-target:
Expand Down
9 changes: 7 additions & 2 deletions src/hyperlight_host/tests/integration_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ use hyperlight_host::{GuestBinary, HyperlightError, MultiUseSandbox, Uninitializ
use hyperlight_testing::simplelogger::{LOGGER, SimpleLogger};
use hyperlight_testing::{c_simple_guest_as_string, simple_guest_as_string};
use log::LevelFilter;
use serial_test::serial;

pub mod common; // pub to disable dead_code warning
use crate::common::{new_uninit, new_uninit_c, new_uninit_rust};
Expand Down Expand Up @@ -293,6 +294,7 @@ fn interrupt_moved_sandbox() {
/// The ABA-problem is solved by clearing CANCEL bit at the start of each VirtualCPU::run() call.
#[test]
#[cfg(target_os = "linux")]
#[serial(thread_heavy)]
fn interrupt_custom_signal_no_and_retry_delay() {
let mut config = SandboxConfiguration::default();
config.set_interrupt_vcpu_sigrtmin_offset(0).unwrap();
Expand All @@ -315,8 +317,8 @@ fn interrupt_custom_signal_no_and_retry_delay() {
let thread = thread::spawn(move || {
for _ in 0..NUM_ITERS {
// wait for the guest call to start
thread::sleep(Duration::from_millis(1000));
interrupt_handle.kill();
thread::sleep(Duration::from_millis(3000));
assert!(interrupt_handle.kill());
}
});

Expand Down Expand Up @@ -864,6 +866,7 @@ fn test_if_guest_is_able_to_get_string_return_values_from_host() {
/// - Calls we did NOT choose to kill NEVER return ExecutionCanceledByHost
/// - We get a mix of killed and non-killed outcomes (not 100% or 0%)
#[test]
#[serial(thread_heavy)]
fn interrupt_random_kill_stress_test() {
// Wrapper to hold a sandbox and its snapshot together
struct SandboxWithSnapshot {
Expand Down Expand Up @@ -1334,6 +1337,7 @@ fn interrupt_random_kill_stress_test() {
///
/// **Failure Condition:** If this test hangs, it means `kill()` failed to stop the guest, leaving it spinning forever.
#[test]
#[serial(thread_heavy)]
fn interrupt_infinite_loop_stress_test() {
use std::sync::{Arc, Barrier};
use std::thread;
Expand Down Expand Up @@ -1421,6 +1425,7 @@ fn interrupt_infinite_loop_stress_test() {
// mid-call and shares a thread ID with another sandbox, ensuring only the intended
// VM is interrupted while bait sandboxes keep running.
#[test]
#[serial(thread_heavy)]
fn interrupt_infinite_moving_loop_stress_test() {
use std::sync::Arc;
use std::thread;
Expand Down