Run thread-heavy integration tests in serial#1216
Open
ludfjig wants to merge 1 commit intohyperlight-dev:mainfrom
Open
Run thread-heavy integration tests in serial#1216ludfjig wants to merge 1 commit intohyperlight-dev:mainfrom
ludfjig wants to merge 1 commit intohyperlight-dev:mainfrom
Conversation
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
320d1dd to
ec68dde
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce CI hangs by preventing the most thread-heavy integration tests from running concurrently and by adjusting timing in an interrupt-related stress test.
Changes:
- Marked several thread-heavy interrupt stress tests to run serially via
serial_test(thread_heavygroup). - Increased the wait duration before sending an interrupt in
interrupt_custom_signal_no_and_retry_delayand assertedkill()succeeds. - Simplified the
Justfileintegration-test invocation by removing the special-case execution ofinterrupt_random_kill_stress_test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/hyperlight_host/tests/integration_test.rs |
Adds serial_test and serializes selected thread-heavy interrupt stress tests; tweaks interrupt timing/assertion in one test. |
Justfile |
Runs integration tests in a single invocation instead of skipping/rerunning one stress test separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tries to fix some recent test hangs that shows up in CI due to thread congestion and
interrupt_infinite_loop_stress_testsleeping for 1000ms not being enough for a sandbox on another thread to enter a guest call. (see here for example)If this doesn't fix it, we can add the attribute to some more thread-heavy tests in sandbox_host_tests, or introduce a barrier in a host call, but hopefully this is sufficient