Register worker SHM mappings for truly async D2H KV copies#369
Draft
Copilot wants to merge 3 commits into
Draft
Conversation
Copilot
AI
changed the title
[WIP] Fix non-blocking GPU memory copy in gather_paged_kv_to_cpu
Register worker SHM mappings for truly async D2H KV copies
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gather_paged_kv_to_cpu(..., out=...)was issuingnon_blocking=TrueD2H copies into SHM-backed CPU buffers, but those worker-side mappings were not registered as pinned host memory in the worker’s CUDA context. As a result, copies to SHM fell back to synchronous behavior despite using the async path.Worker-side SHM host registration
NonGpuContextShmimmediately aftershared_memory.SharedMemory(create=False)succeeds.torch_dev.cudart().cudaHostRegister(..., 0)so the worker’s virtual mapping is recognized by the GPU DMA path.Lifecycle tracking and cleanup
_pinned, pointer, size).cudaHostUnregisterduringclose()before releasing the SHM segment.Graceful fallback on unsupported backends / registration failure
torch_dev.is_available()andhasattr(torch_dev, "cudart").Focused coverage