Skip to content

BE-419: Fix cargo publish failures for darwin-kperf crates #8471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
indietyp wants to merge 5 commits into
base: main
Choose a base branch
from
Open

BE-419: Fix cargo publish failures for darwin-kperf crates #8471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1d3af06
fix: assign concrete versions to packages
indietyp Feb 23, 2026
23049c0
chore: adjust README.md location for darwin-kperf-criterion and friends
indietyp Feb 23, 2026
954078f
chore: bump versions and add crates-io links instead of relative link…
indietyp Feb 23, 2026
6374031
chore: update package.json
indietyp Feb 23, 2026
c57b1ad
fix: version inside of workspace deps
indietyp Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,10 @@ version = "0.0.0"

[workspace.dependencies]
# Workspace members
darwin-kperf.path = "libs/darwin-kperf"
darwin-kperf-criterion.path = "libs/darwin-kperf/criterion"
darwin-kperf-events.path = "libs/darwin-kperf/events"
darwin-kperf-sys.path = "libs/darwin-kperf/sys"
darwin-kperf = { path = "libs/darwin-kperf", version = "0.1.1" }
darwin-kperf-criterion = { path = "libs/darwin-kperf/criterion", version = "0.1.1" }
darwin-kperf-events = { path = "libs/darwin-kperf/events", version = "0.1.1" }
darwin-kperf-sys = { path = "libs/darwin-kperf/sys", version = "0.1.1" }
Comment on lines +62 to +65
Copy link
Contributor

@graphite-app graphite-app bot Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These workspace dependency declarations specify version 0.1.1 for darwin-kperf packages, but when publishing to crates.io, the dependencies must be published before dependents. The CI pipeline needs to publish darwin-kperf-events and darwin-kperf-sys first (which have no dependencies), then darwin-kperf-criterion, and finally darwin-kperf.

Spotted by Graphite Agent (based on CI logs)

Fix in Graphite

Is this helpful? React 👍 or 👎 to let us know.

error-stack = { path = "./libs/error-stack", default-features = false }
harpc-client.path = "libs/@local/harpc/client/rust"
harpc-codec.path = "libs/@local/harpc/codec"
Expand Down
2 changes: 1 addition & 1 deletion libs/darwin-kperf/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "darwin-kperf"
version = "0.1.0"
version = "0.1.1"
authors.workspace = true
edition.workspace = true
license = "MIT OR Apache-2.0"
Expand Down
8 changes: 4 additions & 4 deletions libs/darwin-kperf/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@

| Crate | Description |
| --- | --- |
| [`darwin-kperf`](.) | Safe Rust API for configuring and sampling performance counters |
| [`darwin-kperf-sys`](sys) | Raw FFI bindings to `kperf.framework` and `kperfdata.framework` |
| [`darwin-kperf-events`](events) | Apple Silicon PMU event definitions (M1-M5), auto-generated from plist databases |
| [`darwin-kperf-criterion`](criterion) | Criterion.rs measurement plugin for hardware-counter benchmarking |
| [`darwin-kperf`](https://crates.io/crates/darwin-kperf) | Safe Rust API for configuring and sampling performance counters |
| [`darwin-kperf-sys`](https://crates.io/crates/darwin-kperf-sys) | Raw FFI bindings to `kperf.framework` and `kperfdata.framework` |
| [`darwin-kperf-events`](https://crates.io/crates/darwin-kperf-events) | Apple Silicon PMU event definitions (M1-M5), auto-generated from plist databases |
| [`darwin-kperf-criterion`](https://crates.io/crates/darwin-kperf-criterion) | Criterion.rs measurement plugin for hardware-counter benchmarking |

## Platform support

Expand Down
2 changes: 1 addition & 1 deletion libs/darwin-kperf/codegen/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "darwin-kperf-codegen"
version = "0.1.0"
version = "0.1.1"
authors.workspace = true
edition.workspace = true
license = "MIT OR Apache-2.0"
Expand Down
2 changes: 1 addition & 1 deletion libs/darwin-kperf/codegen/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@rust/darwin-kperf-codegen",
"version": "0.1.0-private",
"version": "0.1.1-private",
"private": true,
"license": "MIT OR Apache-2.0"
}
5 changes: 3 additions & 2 deletions libs/darwin-kperf/criterion/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
[package]
name = "darwin-kperf-criterion"
version = "0.1.0"
version = "0.1.1"
authors.workspace = true
edition.workspace = true
license = "MIT OR Apache-2.0"
publish = true
readme = "../README.md"
description = "Criterion measurement plugin using Apple's hardware performance counters"
documentation = "https://docs.rs/darwin-kperf-criterion"
repository = "https://github.com/hashintel/hash/tree/main/libs/darwin-kperf/criterion"
Expand All @@ -13,7 +14,7 @@ categories = ["development-tools::profiling"]

[dependencies]
# Public workspace dependencies
darwin-kperf-events = { version = "0.1.0", path = "../events", public = true }
darwin-kperf-events = { workspace = true, public = true }
Copy link
Contributor

@graphite-app graphite-app bot Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency specification causes publishing to fail because cargo tries to resolve darwin-kperf-events ^0.1.1 from crates.io during publish, but only 0.1.0 exists there. The publishing order needs to ensure darwin-kperf-events 0.1.1 is published first, or the dependency should be specified with an explicit version that exists on crates.io.

Spotted by Graphite Agent (based on CI logs)

Fix in Graphite

Is this helpful? React 👍 or 👎 to let us know.


# Public third-party dependencies
codspeed-criterion-compat-walltime = { workspace = true, optional = true, public = true, default-features = false }
Expand Down
2 changes: 1 addition & 1 deletion libs/darwin-kperf/criterion/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@rust/darwin-kperf-criterion",
"version": "0.1.0",
"version": "0.1.1",
"private": true,
"description": "Criterion measurement plugin using Apple's hardware performance counters",
"license": "MIT OR Apache-2.0",
Expand Down
3 changes: 2 additions & 1 deletion libs/darwin-kperf/events/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
[package]
name = "darwin-kperf-events"
version = "0.1.0"
version = "0.1.1"
authors.workspace = true
edition.workspace = true
license = "MIT OR Apache-2.0"
publish = true
readme = "../README.md"
description = "Apple Silicon PMU event definitions for darwin-kperf"
documentation = "https://docs.rs/darwin-kperf-events"
repository = "https://github.com/hashintel/hash/tree/main/libs/darwin-kperf/events"
Expand Down
2 changes: 1 addition & 1 deletion libs/darwin-kperf/events/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@rust/darwin-kperf-events",
"version": "0.1.0",
"version": "0.1.1",
"private": true,
"description": "Apple Silicon PMU event definitions for darwin-kperf",
"license": "MIT OR Apache-2.0"
Expand Down
2 changes: 1 addition & 1 deletion libs/darwin-kperf/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@rust/darwin-kperf",
"version": "0.1.0",
"version": "0.1.1",
"private": true,
"description": "Safe Rust bindings for Apple's kperf/kpc hardware performance counters",
"license": "MIT OR Apache-2.0",
Expand Down
3 changes: 2 additions & 1 deletion libs/darwin-kperf/sys/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
[package]
name = "darwin-kperf-sys"
version = "0.1.0"
version = "0.1.1"
authors.workspace = true
edition.workspace = true
license = "MIT OR Apache-2.0"
publish = true
readme = "../README.md"
description = "Raw FFI bindings to Apple's kperf and kperfdata frameworks"
documentation = "https://docs.rs/darwin-kperf-sys"
repository = "https://github.com/hashintel/hash/tree/main/libs/darwin-kperf/sys"
Expand Down
2 changes: 1 addition & 1 deletion libs/darwin-kperf/sys/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@rust/darwin-kperf-sys",
"version": "0.1.0",
"version": "0.1.1",
"private": true,
"description": "Raw FFI bindings to Apple's kperf and kperfdata frameworks",
"license": "MIT OR Apache-2.0",
Expand Down
Loading