Merged
Conversation
Member
|
Can you pin to the hashes like I did in grain-lang/binaryen.ml#201 ? |
Member
Author
|
Done as a separate question do we want to bump the node version we use to at least |
This was referenced Mar 25, 2025
Member
|
22 is fine since it's LTS now. I like it in the other PR. |
ospencer
changed the title
setup-ocaml@v3 and enable v5 buildssetup-ocaml@v3
ospencer
approved these changes
Mar 28, 2025
ospencer
requested changes
Mar 28, 2025
package.json
Outdated
| "license": "Apache-2.0", | ||
| "dependencies": { | ||
| "ocaml": ">= 4.12.0 < 5.0.0", | ||
| "ocaml": ">= 4.13.0 < 5.0.0", |
Member
There was a problem hiding this comment.
This should be updated to support 5.0.x releases:
Suggested change
| "ocaml": ">= 4.13.0 < 5.0.0", | |
| "ocaml": ">= 4.13.0 < 5.1.0", |
Member
Author
There was a problem hiding this comment.
Shouldn't my other pr for supporting ocaml 5 do that?
feat: Support OCaml 5 chore!: Drop support for OCaml 4.12
ospencer
force-pushed
the
spotandjake-dep-upgrade
branch
from
bf96a4b to
bbd8fe7
Compare
Member
|
I fixed up the versions. As long as CI passes this is good to go. |
ospencer
approved these changes
Mar 28, 2025
Member
|
Woo! |
ospencer
pushed a commit
that referenced
this pull request
May 25, 2025
feat: Support OCaml 5 chore!: Drop support for OCaml 4.12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr switches from
setup-ocaml@v2tosetup-ocaml@v3.I was trying to keep the
CCandCCXchanges out of the dune file but I couldn't find a way to override them in the opam file that was platform dependent, and I didn't see a real downside to doing it in the dune file.Note:
4.12.1assetup-ocaml@v2doesn't support it5.3.0in its place so we can hopefully begin moving to ocamlv5Closes: #96