feat!: Require node >= 22 for jsoo 6#114
Merged
ospencer merged 2 commits intograin-lang:mainfrom Mar 30, 2025
Merged
Conversation
ospencer
reviewed
Mar 28, 2025
Member
ospencer
left a comment
ospencer
left a comment
There was a problem hiding this comment.
The suggested changes might result in a change to the lock file. Also, this is breaking because it requires node 22 now.
spotandjake
changed the title
spotandjake
force-pushed
the
spotandjake-ocaml-5
branch
from
fcf1c2d to
5a7d04e
Compare
spotandjake
changed the title
>= 22 for jsoo 6
ospencer
reviewed
Mar 30, 2025
ospencer
approved these changes
Mar 30, 2025
spotandjake
added a commit
to spotandjake/binaryen.ml
that referenced
this pull request
May 17, 2025
This supersedes grain-lang#211 in switching to jsoo 6, the main difference is we need to be using a later version of node on our opam workflows, similar to the changes required here grain-lang/libbinaryen#114
ospencer
pushed a commit
to grain-lang/binaryen.ml
that referenced
this pull request
May 18, 2025
* chore!: Require jsoo >= 6.0 This supersedes #211 in switching to jsoo 6, the main difference is we need to be using a later version of node on our opam workflows, similar to the changes required here grain-lang/libbinaryen#114 * chore: Remove jsoo changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables ocaml
5with esy.This adds the
setup-nodescript to opam workflow as we neednode 22when running the tests see hereBased of: #112
Closes: #88