[Infra] Prefer setup_check.sh over manual config#218
Merged
Conversation
Coverage Report 1Affected Products
Test Logs |
paulb777
approved these changes
Mar 5, 2025
andrewheard
reviewed
Mar 5, 2025
Collaborator
andrewheard
left a comment
andrewheard
left a comment
There was a problem hiding this comment.
Thanks, Nick! This will make it easier to keep up with the clang-format updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies things by getting clang-format from the firebase-ios-sdk checkout during CI rather than from this repo.
Corresponding GoogleDataTransport PR: google/GoogleDataTransport#157