Skip to content

[Infra] Prefer setup_check.sh over manual config#157

Merged
ncooke3 merged 2 commits intomainfrom
ncooke3-patch-2
Mar 5, 2025
Merged

[Infra] Prefer setup_check.sh over manual config#157
ncooke3 merged 2 commits intomainfrom
ncooke3-patch-2

Conversation

@ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Mar 5, 2025

This simplifies things by getting clang-format from the firebase-ios-sdk checkout during CI rather than from this repo.

Corresponding GoogleUtils PR: google/GoogleUtilities#218

@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • GoogleDataTransport-ios-GoogleDataTransport.framework

    Overall coverage changed from 45.26% (c6afba6) to 57.18% (c8058af) by +11.92%.

    29 individual files with coverage change

    FilenameBase (c6afba6)Merge (c8058af)Diff
    GDTCCTCompressionHelper.m81.63%0.00%-81.63%
    GDTCCTNanopbHelpers.m56.04%0.00%-56.04%
    GDTCCTUploader.m89.54%20.26%-69.28%
    GDTCCTUploadOperation.m90.93%0.00%-90.93%
    GDTCCTURLSessionDataResponse.m100.00%0.00%-100.00%
    GDTCORAssert.m0.00%88.89%+88.89%
    GDTCORClock.m71.26%86.21%+14.94%
    GDTCORConsoleLogger.m18.52%74.07%+55.56%
    GDTCORDirectorySizeTracker.m63.79%93.10%+29.31%
    GDTCOREndpoints.m0.00%100.00%+100.00%
    GDTCOREvent+GDTCCTSupport.m35.05%0.00%-35.05%
    GDTCOREvent+GDTMetricsSupport.m75.00%0.00%-75.00%
    GDTCOREvent.m61.80%88.76%+26.97%
    GDTCORFlatFileStorage+Promises.m0.00%27.43%+27.43%
    GDTCORFlatFileStorage.m13.44%91.01%+77.57%
    GDTCORLifecycle.m40.74%55.56%+14.81%
    GDTCORLogSourceMetrics.m52.17%94.78%+42.61%
    GDTCORMetrics+GDTCCTSupport.m93.75%0.00%-93.75%
    GDTCORMetrics.m47.27%30.91%-16.36%
    GDTCORMetricsController.m16.28%94.77%+78.49%
    GDTCORMetricsMetadata.m0.00%100.00%+100.00%
    GDTCORPlatform.m59.18%71.84%+12.66%
    GDTCORProductData.m42.11%84.21%+42.11%
    GDTCORRegistrar.m76.72%74.60%-2.12%
    GDTCORStorageMetadata.m0.00%100.00%+100.00%
    GDTCORTransformer.m0.00%91.26%+91.26%
    GDTCORTransport.m0.00%81.25%+81.25%
    GDTCORUploadBatch.m100.00%0.00%-100.00%
    GDTCORUploadCoordinator.m59.74%79.87%+20.13%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/IY2yYn09bc.html

@ncooke3 ncooke3 merged commit 19d440e into main Mar 5, 2025
15 checks passed
@ncooke3 ncooke3 deleted the ncooke3-patch-2 branch March 5, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants