refactor: harmonize resolution-file existence checks across market sources#204
Merged
houtanb merged 1 commit intoJun 15, 2026
Conversation
nikbpetrov
force-pushed
the
fix-existing-files-arg-semantics
branch
from
34a28e9 to
0f091ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this one makes me quite happy as those args to
fetch()/update()now make sense!!!and the fact that we are getting rid of that inline source-name-id construction/deconstruction is just the cherry on top!
if you agree with this direction on a quick pass, i will run full parity tests for this PR (would classify this as potentially dangerous in case I've not constructed/reconstructed properly somewhere and had a dormant bug).