Update build resolution df semantics and fix duplication validation#215
Merged
houtanb merged 3 commits intoJun 15, 2026
Merged
Conversation
Supersedes PR forecastingresearch#209 and forecastingresearch#208. Fixes issue forecastingresearch#206
Supersedes PR forecastingresearch#209 and forecastingresearch#208. Fixes issue forecastingresearch#206
This was referenced Jun 10, 2026
nikbpetrov
added a commit
to nikbpetrov/forecastbench
that referenced
this pull request
Jun 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #208 #209 and fixes #206
Based on #204
Note that infer keeps the
_finalize_resolution_dfunlike some other sources - avoid duplication and perfectly fine (there is no base class enforcement of these anyways, just for readability)