Skip to content

[Homepage] fix: Hardcode PUID and PGID values #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
finallyjay merged 2 commits into from
Apr 8, 2026
Merged

[Homepage] fix: Hardcode PUID and PGID values #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9959129
[Homepage] fix: Hardcode PUID and PGID values
finallyjay Apr 8, 2026
c6d88b3
[Homepage] fix: Remove PUID/PGID from README
finallyjay Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions homepage/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ via Docker socket labels.
|--------------------------|-----------------------------------|
| `HOMEPAGE_DATA` | Local path for configuration files|
| `HOMEPAGE_ALLOWED_HOSTS` | Allowed hostnames for access |
| `PUID` | User ID for file permissions |
| `PGID` | Group ID for file permissions |

## Networks

Expand Down
4 changes: 2 additions & 2 deletions homepage/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ services:
- ${HOMEPAGE_DATA}/config:/app/config
environment:
HOMEPAGE_ALLOWED_HOSTS: ${HOMEPAGE_ALLOWED_HOSTS}
PUID: $PUID
PGID: $PGID
PUID: 1000
PGID: 1000
Comment on lines 20 to +23
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoding PUID/PGID to 1000 removes the ability to run Homepage under a different host UID/GID and also makes the service docs inaccurate (homepage/README.md still documents PUID/PGID as configurable env vars). Consider switching to Compose interpolation defaults (e.g., allow overriding while defaulting to 1000) and/or update the service README to reflect that these values are fixed.

Copilot uses AI. Check for mistakes.
Comment on lines +22 to +23
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Compose, environment values are strings; using unquoted YAML integers (1000) can cause schema validation issues or type surprises in tooling. Quote these values (or use string interpolation) so they remain explicit strings.

Copilot uses AI. Check for mistakes.
logging:
driver: json-file
options:
Expand Down
Loading