[Homepage] fix: Hardcode PUID and PGID values#24
Conversation
Replaces env var references with direct values (1000) since these rarely change and were not documented in .env.example. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the Homepage service’s Docker Compose configuration to stop referencing PUID/PGID variables and instead run with fixed UID/GID values.
Changes:
- Replaced
PUID/PGIDenvironment variable references with hardcoded1000. - Kept existing
HOMEPAGE_ALLOWED_HOSTSenvironment interpolation unchanged.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| environment: | ||
| HOMEPAGE_ALLOWED_HOSTS: ${HOMEPAGE_ALLOWED_HOSTS} | ||
| PUID: $PUID | ||
| PGID: $PGID | ||
| PUID: 1000 | ||
| PGID: 1000 |
There was a problem hiding this comment.
Hardcoding PUID/PGID to 1000 removes the ability to run Homepage under a different host UID/GID and also makes the service docs inaccurate (homepage/README.md still documents PUID/PGID as configurable env vars). Consider switching to Compose interpolation defaults (e.g., allow overriding while defaulting to 1000) and/or update the service README to reflect that these values are fixed.
| PUID: 1000 | ||
| PGID: 1000 |
There was a problem hiding this comment.
In Compose, environment values are strings; using unquoted YAML integers (1000) can cause schema validation issues or type surprises in tooling. Quote these values (or use string interpolation) so they remain explicit strings.
These are no longer environment variables after hardcoding them in docker-compose.yml. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
$PUIDand$PGIDenv var references with hardcoded1000values.env.exampleTest plan