Skip to content

Improve ESM compatibility #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Phillip9587 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve ESM compatibility #697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5740886
fix: use static exports instead of lazy getters
Phillip9587 Jan 16, 2026
047691b
feat: add subpath exports for individual parsers
Phillip9587 Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 4 additions & 20 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,41 +24,25 @@ exports = module.exports = bodyParser
* JSON parser.
* @public
*/
Object.defineProperty(exports, 'json', {
configurable: true,
enumerable: true,
get: () => require('./lib/types/json')
})
exports.json = require('./lib/types/json')

/**
* Raw parser.
* @public
*/
Object.defineProperty(exports, 'raw', {
configurable: true,
enumerable: true,
get: () => require('./lib/types/raw')
})
exports.raw = require('./lib/types/raw')

/**
* Text parser.
* @public
*/
Object.defineProperty(exports, 'text', {
configurable: true,
enumerable: true,
get: () => require('./lib/types/text')
})
exports.text = require('./lib/types/text')

/**
* URL-encoded parser.
* @public
*/
Object.defineProperty(exports, 'urlencoded', {
configurable: true,
enumerable: true,
get: () => require('./lib/types/urlencoded')
})
exports.urlencoded = require('./lib/types/urlencoded')

/**
* Create a middleware to parse json and urlencoded bodies.
Expand Down
8 changes: 8 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,14 @@
"type": "opencollective",
"url": "https://opencollective.com/express"
},
"exports": {
".": "./index.js",
"./package.json": "./package.json",
Copy link
Member

@bjohansebas bjohansebas Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would it be necessary to add the package.json?

Copy link
Member Author

@Phillip9587 Phillip9587 Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added ./package.json to the exports field to avoid breaking existing tooling and user setups that rely on require('body-parser/package.json') to read metadata (e.g. version info). Once exports is defined, Node.js treats it as an allowlist, so this preserves backward compatibility.

Docs: https://nodejs.org/api/packages.html#package-entry-points

"./json": "./lib/types/json.js",
"./raw": "./lib/types/raw.js",
"./text": "./lib/types/text.js",
"./urlencoded": "./lib/types/urlencoded.js"
},
"dependencies": {
"bytes": "^3.1.2",
"content-type": "^1.0.5",
Expand Down