Improve ESM compatibility #697
Open
+12
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Static exports allow Node.js cjs-module-lexer to detect named exports correctly, improving ESM interop and bundler behavior.
Add an exports field to package.json exposing json, raw, text,
and urlencoded parsers as subpath exports.
This allows consumers to import individual parsers directly:
- CommonJS: require('body-parser/json')
- ESM: import json from 'body-parser/json'
The change is fully backward compatible and enables users to
opt into loading only the parsers they need.
bjohansebas
reviewed
Jan 16, 2026
| }, | ||
| "exports": { | ||
| ".": "./index.js", | ||
| "./package.json": "./package.json", |
Member
There was a problem hiding this comment.
Why would it be necessary to add the package.json?
Member
Author
There was a problem hiding this comment.
I added ./package.json to the exports field to avoid breaking existing tooling and user setups that rely on require('body-parser/package.json') to read metadata (e.g. version info). Once exports is defined, Node.js treats it as an allowlist, so this preserves backward compatibility.
Docs: https://nodejs.org/api/packages.html#package-entry-points
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #666 (comment)
This PR contains 2 commits:
fix: use static exports instead of lazy getters
Static exports allow Node.js
cjs-module-lexerto detect namedexports correctly, improving ESM interop and bundler behavior.
feat: add subpath exports for individual parsers
Add an exports field to package.json exposing json, raw, text,
and urlencoded parsers as subpath exports.
This allows consumers to import individual parsers directly:
The change is fully backward compatible and enables users to
opt into loading only the parsers they need.
Closes #666