fix(versioncheck): detect mise install for update command#659
Merged
Soph merged 2 commits intoentireio:mainfrom Mar 10, 2026
Merged
fix(versioncheck): detect mise install for update command#659Soph merged 2 commits intoentireio:mainfrom
Soph merged 2 commits intoentireio:mainfrom
Conversation
When the binary is installed via mise, show `mise upgrade entire` instead of the curl command. Detection is path-based (checking for /mise/ in the resolved binary path), consistent with the existing Homebrew detection. Closes entireio#432 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Entire-Checkpoint: 46875b53634f
Soph
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #432
When the CLI detects a newer version is available, it shows an update command. Previously it only distinguished between Homebrew (
brew upgrade entire) and the install script. Users who installed viamisewere shown the generic install script command instead ofmise upgrade entire.This adds mise detection by checking if the resolved binary path contains
/mise/, using the same symlink-resolution pattern already used for Homebrew detection.Changes
versioncheck/versioncheck.go- Added mise path check inupdateCommand()before the fallbackversioncheck/versioncheck_test.go- Added"mise upgrade entire"to valid update commandsTesting
TestUpdateCommandvalidates the new command is in the accepted setfilepath.EvalSymlinks+strings.Containspattern as Homebrew🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com