Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions cmd/entire/cli/strategy/hook_managers.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,14 @@ func detectHookManagers(repoRoot string) []hookManager {
}
}

// hk supports {.config/,}hk{,.local}.pkl
for _, dir := range []string{"", ".config/"} {
for _, variant := range []string{"", ".local"} {
name := dir + "hk" + variant + ".pkl"
checks = append(checks, hookManager{"hk", name, false})
}
}

seen := make(map[string]bool)
for _, c := range checks {
path := filepath.Join(repoRoot, c.ConfigPath)
Expand Down
88 changes: 88 additions & 0 deletions cmd/entire/cli/strategy/hook_managers_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,94 @@ func TestDetectHookManagers_Overcommit(t *testing.T) {
}
}

func TestDetectHookManagers_Hk(t *testing.T) {
t.Parallel()

tmpDir := t.TempDir()
if err := os.WriteFile(filepath.Join(tmpDir, "hk.pkl"), []byte(""), 0o644); err != nil {
t.Fatalf("failed to create hk.pkl: %v", err)
}

managers := detectHookManagers(tmpDir)
if len(managers) != 1 {
t.Fatalf("expected 1 manager, got %d", len(managers))
}
if managers[0].Name != "hk" {
t.Errorf("expected hk, got %s", managers[0].Name)
}
if managers[0].ConfigPath != "hk.pkl" {
t.Errorf("expected hk.pkl, got %s", managers[0].ConfigPath)
}
if managers[0].OverwritesHooks {
t.Error("hk should have OverwritesHooks=false")
}
}

func TestDetectHookManagers_HkConfigDir(t *testing.T) {
t.Parallel()

tmpDir := t.TempDir()
configDir := filepath.Join(tmpDir, ".config")
if err := os.MkdirAll(configDir, 0o755); err != nil {
t.Fatalf("failed to create .config/: %v", err)
}
if err := os.WriteFile(filepath.Join(configDir, "hk.pkl"), []byte(""), 0o644); err != nil {
t.Fatalf("failed to create .config/hk.pkl: %v", err)
}

managers := detectHookManagers(tmpDir)
if len(managers) != 1 {
t.Fatalf("expected 1 manager, got %d", len(managers))
}
if managers[0].Name != "hk" {
t.Errorf("expected hk, got %s", managers[0].Name)
}
if managers[0].ConfigPath != ".config/hk.pkl" {
t.Errorf("expected .config/hk.pkl, got %s", managers[0].ConfigPath)
}
}

func TestDetectHookManagers_HkLocal(t *testing.T) {
t.Parallel()

tmpDir := t.TempDir()
if err := os.WriteFile(filepath.Join(tmpDir, "hk.local.pkl"), []byte(""), 0o644); err != nil {
t.Fatalf("failed to create hk.local.pkl: %v", err)
}

managers := detectHookManagers(tmpDir)
if len(managers) != 1 {
t.Fatalf("expected 1 manager, got %d", len(managers))
}
if managers[0].Name != "hk" {
t.Errorf("expected hk, got %s", managers[0].Name)
}
if managers[0].ConfigPath != "hk.local.pkl" {
t.Errorf("expected hk.local.pkl, got %s", managers[0].ConfigPath)
}
}

func TestDetectHookManagers_HkDedup(t *testing.T) {
t.Parallel()

tmpDir := t.TempDir()
// Both hk.pkl and hk.local.pkl present — should only report once
if err := os.WriteFile(filepath.Join(tmpDir, "hk.pkl"), []byte(""), 0o644); err != nil {
t.Fatalf("failed to create hk.pkl: %v", err)
}
if err := os.WriteFile(filepath.Join(tmpDir, "hk.local.pkl"), []byte(""), 0o644); err != nil {
t.Fatalf("failed to create hk.local.pkl: %v", err)
}

managers := detectHookManagers(tmpDir)
if len(managers) != 1 {
t.Fatalf("expected 1 manager (dedup), got %d", len(managers))
}
if managers[0].Name != "hk" {
t.Errorf("expected hk, got %s", managers[0].Name)
}
}

func TestDetectHookManagers_Multiple(t *testing.T) {
t.Parallel()

Expand Down
Loading