feat(hooks): add hk to detected hook managers#657
Open
mvanhorn wants to merge 1 commit intoentireio:mainfrom
Open
feat(hooks): add hk to detected hook managers#657mvanhorn wants to merge 1 commit intoentireio:mainfrom
mvanhorn wants to merge 1 commit intoentireio:mainfrom
Conversation
Detect hk (https://hk.jdx.dev) config files during `entire enable`. hk uses .pkl config files in the repo root or .config/ directory: hk.pkl, hk.local.pkl, .config/hk.pkl, .config/hk.local.pkl Closes entireio#610 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #610
Adds detection for hk as an external hook manager, following the same filesystem-based detection pattern used for Husky, Lefthook, and other existing hook managers.
hk uses
.pklconfig files with four possible locations:hk.pkl(root)hk.local.pkl(root, local override).config/hk.pkl(config dir).config/hk.local.pkl(config dir, local override)All four variants are checked, and results are deduplicated so
hkonly appears once in the detected list regardless of how many config files exist.Changes
hook_managers.go- Added hk detection block generating checks for all 4 config file variantshook_managers_test.go- Added 4 tests: basic detection,.config/dir variant,.localvariant, and deduplication across multiple config filesTesting
testutil.InitRepo,t.Parallel())🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com