DataLex theme: shared-contract alignment (white theme + minimal embed shim)#114
Merged
Conversation
On datalex.theme with a mode, fire the Shell's datalex:theme-change hook so the embedded DataLex flips light/dark with the cloud, not just a few color tokens. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Set localStorage['datalex.theme'] so the Shell's initial state adopts the cloud theme even when the message arrives before the live listener mounts. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Theme+mode, x-oss-app + bearer fetch wrap, capability-driven chrome-hiding, cloud-context injection, route reporting and the ready handshake are now driven from OUTSIDE the OSS app by the cloud's build-injected embed adapter (governed-analytics-cloud: scripts/embed-adapter.js) + its override CSS. This shim keeps only per-project localStorage isolation. Standalone DataLex is unaffected (no-op without ?embedded=1). Builds clean (vite). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Namespacing hid the cloud adapter's pre-boot dm_theme write behind a project-scoped key the uiStore never reads, so the embedded DataLex theme never applied (stuck dark). The cloud owns embedded UI state; the shim is now just the embed flag + cloud-context reader. Builds clean (vite). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Adds a [data-theme="white"] block (crisp light) mirroring the paper block, using the canonical white values from the shared contract (@duckcodeai/design-tokens). This lets the cloud global "white" theme map 1:1 onto DataLex instead of falling back to arctic. Core vars (bg/text/accent/border) use the canonical white; DataLex-specific extras (pk/fk/idx, cat-*, sql-*) are tuned to match. Builds clean (vite). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the cloud-embed theme work onto main so code matches the AGENTS.md contract: adds the
whitetheme (maps the cloud global white 1:1), drives the real theme mechanism (data-theme + dm_theme), and reduces the embed shim to a minimal stub (no localStorage namespacing, which was hiding the theme key). Merged main in (no conflicts); builds clean. Standalone DataLex unaffected (shim is a no-op without ?embedded=1).