Skip to content

fix(shader): recover gracefully from GLSL compile/link failures instead of crashing#583

Merged
drsnuggles8 merged 2 commits into
masterfrom
fix/shader-compile-crash-recoverable
Jul 7, 2026
Merged

fix(shader): recover gracefully from GLSL compile/link failures instead of crashing#583
drsnuggles8 merged 2 commits into
masterfrom
fix/shader-compile-crash-recoverable

fix(shader): address review findings on the #568 crash-fix diff

2ed360c
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jul 7, 2026 in 51m 16s

Annotations

Check warning on line 1480 in OloEngine/src/Platform/OpenGL/OpenGLShader.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

implicit conversion changes signedness: 'int' to 'size_type' (aka 'unsigned long long')

See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ89Pee40QN_ogQ2SE8_&open=AZ89Pee40QN_ogQ2SE8_&pullRequest=583

Check warning on line 1481 in OloEngine/src/Platform/OpenGL/OpenGLShader.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

implicit conversion changes signedness: 'int' to 'size_type' (aka 'unsigned long long')

See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ89Pee40QN_ogQ2SE9A&open=AZ89Pee40QN_ogQ2SE9A&pullRequest=583

Check warning on line 165 in OloEngine/src/Platform/OpenGL/OpenGLShader.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add message to "[[nodiscard]]" attribute explaining why the return value should not be discarded.

See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ89PesR0QN_ogQ2SE9D&open=AZ89PesR0QN_ogQ2SE9D&pullRequest=583

Check warning on line 158 in OloEngine/src/Platform/OpenGL/OpenGLShader.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add message to "[[nodiscard]]" attribute explaining why the return value should not be discarded.

See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ89PesR0QN_ogQ2SE9B&open=AZ89PesR0QN_ogQ2SE9B&pullRequest=583

Check warning on line 159 in OloEngine/src/Platform/OpenGL/OpenGLShader.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add message to "[[nodiscard]]" attribute explaining why the return value should not be discarded.

See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ89PesR0QN_ogQ2SE9C&open=AZ89PesR0QN_ogQ2SE9C&pullRequest=583