Conversation
Standardize markdown syntax across all documentation files: - Replace YAML-style separators (----) with three-dash (---) format - Consistently format titles with single quotes for proper escaping - Normalize code block delimiters and structure - Apply consistent heading and separator styles - No content changes, purely formatting improvements
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements a broad update to the Taskiq-Flow documentation, focusing on Liquid tag integration for code blocks and general formatting enhancements. The review feedback highlights several technical issues in the documentation's code snippets, such as missing arguments in API setup functions, the invocation of a non-existent run_pipeline method, and missing imports for core exceptions. Additionally, the reviewer pointed out inconsistencies in decorator examples and identified various typographical and spacing errors that need to be resolved to ensure the documentation is accurate and consistent.
| {% endraw %} | ||
|
|
||
| Instrumentator().instrument(app).expose(app, endpoint="/metrics") | ||
| {% raw %} |
There was a problem hiding this comment.
L'exception TaskiqError est utilisée dans la signature de la fonction mais n'est pas importée dans cet extrait de code. Il faudrait ajouter from taskiq import TaskiqError.
| return await super().schedule_task(task_node, inputs) | ||
|
|
||
| engine = GPUOptimizedEngine(broker, dag) | ||
| results = await engine.execute(inputs) |
There was a problem hiding this comment.
L'utilisation du décorateur @pipeline.task est incohérente avec le reste de la documentation qui préconise l'utilisation combinée de @broker.task et @pipeline_task.
| broker=broker, | ||
| max_parallel=10, | ||
| ) | ||
| executor.run_pipeline(pipeline, input_data) |
There was a problem hiding this comment.
La méthode run_pipeline n'existe pas sur la classe ResourceAwareExecutor. Cet exécuteur doit être utilisé pour obtenir le parallélisme optimal via get_optimal_parallelism, qui est ensuite appliqué au pipeline avant son exécution via kiq_dataflow.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 participant
No description provided.