Skip to content

pass through USER/HOME to op cli #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theoephraim merged 3 commits into from
Apr 9, 2026
Merged

pass through USER/HOME to op cli #564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6eeb631
pass through USER/HOME to op cli
theoephraim Apr 7, 2026
f66ba09
pass through xdg home too
theoephraim Apr 8, 2026
2d2e44a
explicitly enable OP_BIOMETRIC_UNLOCK_ENABLED
theoephraim Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/bold-trees-relate.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@varlock/1password-plugin": patch
---

pass through USER and HOME to op cli calls
9 changes: 7 additions & 2 deletions packages/plugins/1password/src/cli-helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,9 +202,14 @@ async function executeReadBatch(batchToExecute: NonNullable<typeof opReadBatch>)
// because otherwise we'll have trouble dealing with values that contain newlines
await spawnAsync('op', `run --no-masking ${lockCliToOpAccount ? `--account ${lockCliToOpAccount} ` : ''}-- env -0`.split(' '), {
env: {
// have to pass through at least path so it can find `op`, but might need other items too?
// have to pass a few things through at least path so it can find `op` and related config files
PATH: process.env.PATH!,
// ...process.env as any,
...process.env.USER && { USER: process.env.USER },
...process.env.HOME && { HOME: process.env.HOME },
...process.env.XDG_CONFIG_HOME && { XDG_CONFIG_HOME: process.env.XDG_CONFIG_HOME },
// this setting actually just enables the CLI + Desktop App integration
// which in some cases op has a hard time detecting via app setting
OP_BIOMETRIC_UNLOCK_ENABLED: 'true',
...envMap,
},
})
Expand Down
Loading