Skip to content

pass through USER/HOME to op cli#564

Open
theoephraim wants to merge 2 commits intomainfrom
bug/1p-brew-multi-user
Open

pass through USER/HOME to op cli#564
theoephraim wants to merge 2 commits intomainfrom
bug/1p-brew-multi-user

Conversation

@theoephraim
Copy link
Copy Markdown
Member

@theoephraim theoephraim commented Apr 7, 2026

passes through USER and HOME env vars to op cli calls within 1password plugin. This is to fix op plugin behaviour on machines where op is installed via brew in a multi-user setup.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 7, 2026

🦋 Changeset detected

Latest commit: f66ba09

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@varlock/1password-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 7, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@varlock/ci-env-info@564
npm i https://pkg.pr.new/@varlock/1password-plugin@564

commit: f66ba09

@theoephraim
Copy link
Copy Markdown
Member Author

user reports they still need OP_BIOMETRIC_UNLOCK_ENABLED although I'm unclear why it's different on their system. We can probably just always pass through OP_BIOMETRIC_UNLOCK_ENABLED=true since this code path is only called when using the cli specifically for biometric auth.

@philmillman
Copy link
Copy Markdown
Member

user reports they still need OP_BIOMETRIC_UNLOCK_ENABLED although I'm unclear why it's different on their system. We can probably just always pass through OP_BIOMETRIC_UNLOCK_ENABLED=true since this code path is only called when using the cli specifically for biometric auth.

is it always going to be biometric though? won't it just default to whatever the system level auth is?

@theoephraim
Copy link
Copy Markdown
Member Author

the docs claim the setting

Toggles the 1Password app integration on or off.

so... 🤷

@philmillman
Copy link
Copy Markdown
Member

the docs claim the setting

Toggles the 1Password app integration on or off.

so... 🤷

gotcha, naming things is hard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants