feat(wallet-lib): rework storage for multiple key chains#231
Merged
Conversation
4 tasks
Collaborator
|
We decided to do not to merge it yet to v0.22. We probably should merge it to v0.22.x-dev? |
markin-io
approved these changes
Feb 7, 2022
markin-io
changed the title
markin-io
pushed a commit
that referenced
this pull request
Apr 25, 2022
5 tasks
markin-io
pushed a commit
that referenced
this pull request
Apr 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
In dashevo/wallet-lib#351, we introduced multiple features that couldn't be managed as is due to their size.
This PR only adds two new types allowing future registration of derivation path via the introduction of DerivableKeyChain and its KeyChainStore manager.
It does not modify the current state (similar insertion to with ChainStore and WalletStore).
What was done?
How Has This Been Tested?
Breaking Changes
N/A
Checklist:
For repository code-owners and collaborators only