Skip to content

chore(js-dash-sdk): merge features and refactorings #358

Merged
markin-io merged 8 commits into
masterfrom
chore/merge-sdk-features-for-release
Apr 27, 2022
Merged

chore(js-dash-sdk): merge features and refactorings #358
markin-io merged 8 commits into
masterfrom
chore/merge-sdk-features-for-release

Conversation

@markin-io
Copy link
Copy Markdown
Contributor

@markin-io markin-io commented Apr 25, 2022

Issue being fixed or feature implemented

Pull request includes the next set of features and fixes:

What was done?

Cherry-picked merge commits and fixed inconsistencies

How Has This Been Tested?

  • CI
  • Running platform-test-suite against testnet (each e2e/functional test separately)
  • Run through the tutorial

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Alex-Werner and others added 7 commits April 25, 2022 15:39
Co-authored-by: Igor Markin <igor.markin@dash.org>
Co-authored-by: markin.io <markin.io210@gmail.com>
…337)

* feat: adds balance and metadata information from registered identity

* fix: use setter method for identity
* feat: provide transaction history item as a date object

* style: fix lint

* docs: update documentation

* docs: fix documentation conflict

* fix: conflict
Co-authored-by: Mikhail Pshenichnikov <pshenmic@gmail.com>
Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
@markin-io markin-io added the js-sdk JS Dash SDK related label Apr 25, 2022
@markin-io markin-io added this to the v0.23.0 milestone Apr 25, 2022
@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Apr 25, 2022

This pull request introduces 2 alerts when merging 2ff87ef into 4f772ba - view on LGTM.com

new alerts:

  • 2 for Ineffective parameter type

@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Apr 25, 2022

This pull request introduces 2 alerts when merging 2e8a61a into 4f772ba - view on LGTM.com

new alerts:

  • 2 for Ineffective parameter type

@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Apr 25, 2022

This pull request introduces 2 alerts when merging 3cbac5f into 4f772ba - view on LGTM.com

new alerts:

  • 2 for Ineffective parameter type

@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Apr 26, 2022

This pull request introduces 2 alerts when merging 8df0af5 into 4f772ba - view on LGTM.com

new alerts:

  • 2 for Ineffective parameter type

@markin-io markin-io marked this pull request as ready for review April 27, 2022 04:56
@markin-io markin-io requested a review from pshenmic April 27, 2022 04:56
@markin-io markin-io changed the title chore: merge sdk features chore(js-dash-sdk): merge features and refactorings Apr 27, 2022
shumkov
shumkov previously approved these changes Apr 27, 2022
Copy link
Copy Markdown
Collaborator

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@markin-io markin-io force-pushed the chore/merge-sdk-features-for-release branch from 8df0af5 to 8a9b526 Compare April 27, 2022 06:38
@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Apr 27, 2022

This pull request introduces 2 alerts when merging 8a9b526 into 4f772ba - view on LGTM.com

new alerts:

  • 2 for Ineffective parameter type

Copy link
Copy Markdown
Collaborator

@pshenmic pshenmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

@markin-io markin-io merged commit 0710250 into master Apr 27, 2022
@markin-io markin-io deleted the chore/merge-sdk-features-for-release branch April 27, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

js-sdk JS Dash SDK related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants