feat(qt): UI refresh (4/n, introduce distinct widgets for Dash-specific reporting in debug window, governance stats) by kwvg · Pull Request #7118 · dashpay/dash

kwvg · 2026-01-28T19:20:30Z

Additional Information

Depends on refactor(qt): UI refresh (1/n, runtime show/hide of "Governance" and "Masternode" tabs, split out proposal model, additional bounds checking, better QTextEdit styling) #7112
Depends on feat(qt): UI refresh (2/n, update "Governance" Tab layout, lifecycle icons, description dialogs, resumable proposal creation) #7110

v23.0.2 (`cdc5a63`)	This PR (WIP code)

Does not exist in this build
Does not exist in this build
Does not exist in this build

Breaking Changes

None expected.

Checklist

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated relevant unit/integration/functional/e2e tests
I have made corresponding changes to the documentation
I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

github-actions · 2026-01-28T19:21:14Z

⚠️ Potential Merge Conflicts Detected

This PR has potential conflicts with the following open PRs:

refactor: new chainlock::Chainlocks interface #7113 - refactor: new chainlock::Chainlocks interface
refactor: move MnemonicVerificationDialog css, drop excessive styling #7040 - refactor: move MnemonicVerificationDialog css, drop excessive styling
refactor(qt): UI refresh (1/n, runtime show/hide of "Governance" and "Masternode" tabs, split out proposal model, additional bounds checking, better QTextEdit styling) #7112 - refactor(qt): UI refresh (1/n, runtime show/hide of "Governance" and "Masternode" tabs, split out proposal model, additional bounds checking, better QTextEdit styling)

Please coordinate with the authors of these PRs to avoid merge conflicts.

Also `s/coinJoinEnabledChanged/showCoinJoinChanged/g` to establish a naming convention that will be used soon.

This should fix the misalignment of the `subFeeFromAmount` `QCheckBox` compared to the rest of the `QCheckBox`es Review with `git log -p -n1 --ignore-space-change --color-moved=dimmed_zebra`.

Review with `git log -p -n1 --color-moved=dimmed_zebra`.

Inheriting the whole structure is overkill just to use `tr` and `hash()` is used in hot loops so we should cache the value in the ctor. Also remove dead variable.

Review with `git log -p -n1 --ignore-space-change --color-moved=dimmed_zebra`.

This is closer to how we report details for transactions and more translation-friendly and easier to copy.

Visiting URLs could be dangerous, add a warning before we open a link in someone's browser.

Dash Governance Tools' budget generator is a much more visually friendly design and we can model our wizard after it.

The JSON and payload hex means little for the vast majority of users, what matters is the error messages, so we responsively validate contents and drop an extra panel in the process.

The visual language should match other coin-spending activities, also warn that that you don't get the fee back.

The proposal creation process can be interrupted for reasons beyond our control, since submitting the actual proposal is different from spending the collateral, it should have its own page. Right now this removes the old code but doesn't create a new layout, we will do that in the next commit.

This replaces the remaining pages of the proposal wizard that we removed in the last commit.

You cannot create a proposal without an adequate balance, it's a bad idea to allow any kind of proposal manipulation without being synced.

This is a more inexpensive operation since we aren't getting a diff set, we're getting the whole list repeatedly.

We are no longer using the wizard format so the name is a misnomer, the logic is also relatively simplified (as now half of it is in `qt/proposalresume.{cpp,h}`)

Applying our font causes drift to be introduced for some reason if baked into the layout but this doesn't seem to be an issue if done programmatically

Review with `git log -p -n1 --color-moved=dimmed_zebra`.

thephez · 2026-01-28T20:47:42Z

@kwvg would it be difficult to also add the age of the quorums in addition to their health? On testnet some of those quorums haven't formed for years if I'm not mistaken. Would be nice to know if quorums were "fresh" and when the next ones are expected to form.

github-actions · 2026-02-03T14:01:42Z

This pull request has conflicts, please rebase.

…use `UniValue` instead of `QJsonObject`, consistency in tab hiding behavior, minor bugfixes 3329898 chore: remove redundant `std::nullopt` from default init (Kittywhiskers Van Gogh) d9b141a qt: use use `QHash`/`QSet` instead of `std::{map,set}` (Kittywhiskers Van Gogh) ce747c8 qt: add vote signing to wallet interface (Kittywhiskers Van Gogh) 66f2e80 fix: check for `llmq_ctx` before accessing `isman` (Kittywhiskers Van Gogh) ec5fb20 fix: avoid double-free by clearing before dtor semaphore cleanup (Kittywhiskers Van Gogh) 3ee43d9 fix: switch back to overview page if tab disabled (Kittywhiskers Van Gogh) c8ce943 fix: use UniValue instead of QJsonObject to construct proposal (Kittywhiskers Van Gogh) abb9aa1 fix: use wider integer to avoid potential overflow scenarios (Kittywhiskers Van Gogh) 6b90182 fix: acknowledge `updateDIP3List()` fail states (Kittywhiskers Van Gogh) 14b494c fix: avoid potential reassignment of atomic `m_mn_list_changed` (Kittywhiskers Van Gogh) 3b68a2d fix: emit `dataChanged()` when the display unit changes. (Kittywhiskers Van Gogh) 8ab5c0c fix: don't include invisible/hidden tabs in width calculations (Kittywhiskers Van Gogh) 99fd118 fix: avoid precision loss, storing as `CAmount`, fix potential overflow (Kittywhiskers Van Gogh) 72ed0ed fix: remove unused `m_node` in `ProposalWizard` (Kittywhiskers Van Gogh) Pull request description: ## Additional Information Resolution of preexisting bugs in `develop`, review feedback from [dash#7112](#7112) and [dash#7116](#7116) and fixes for bugs discovered when working on [dash#7118](#7118). ## Breaking Changes None expected. ## Checklist - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added or updated relevant unit/integration/functional/e2e tests **(note: N/A)** - [x] I have made corresponding changes to the documentation **(note: N/A)** - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: UdjinM6: utACK 3329898 knst: utACK 3329898 Tree-SHA512: 5437fa59ae6cd7a7f3d6bfc4167f8562265c0395cd3a92bcbc7c1d97541e25cd373f6f0808d58a503855469875c33d5e08d8b2041fee2c2a001416653f8cca7f

kwvg added this to the 23.1 milestone Jan 28, 2026

kwvg added 28 commits January 29, 2026 01:07

refactor: drop emitCoinJoinEnabledChanged(), use setOption() instead

17491eb

refactor: improve CoinJoin tab nullptr checks, bail-out condition

2deba78

Also `s/coinJoinEnabledChanged/showCoinJoinChanged/g` to establish a naming convention that will be used soon.

move-only: move subFeeFromAmount into verticalLayout_2

8a0907c

This should fix the misalignment of the `subFeeFromAmount` `QCheckBox` compared to the rest of the `QCheckBox`es Review with `git log -p -n1 --ignore-space-change --color-moved=dimmed_zebra`.

chore: enforce alphabetical sorting in src/Makefile.qt.include

45da71c

Review with `git log -p -n1 --color-moved=dimmed_zebra`.

refactor: add getScaledFont helper, keep getFont internal

c8558b8

refactor: add pruneStaleEntities helper to deduplicate pruning

1c7cfcc

move-only: split proposal model out to src/qt/proposalmodel.{cpp,h}

fa48b81

Review with `git log -p -n1 --color-moved=dimmed_zebra`.

fix: use unique_ptr and more bounds checking in qt/proposalmodel

a709391

refactor: drop QObject inheritance, precalculate hash string

ae70706

Inheriting the whole structure is overkill just to use `tr` and `hash()` is used in hot loops so we should cache the value in the ctor. Also remove dead variable.

qt: add styling support for QTextEdit <b> and <h{1-3}> elements

8a7f4e9

qt: use show/hide for "Governance" tab to avoid client restart

804a239

refactor: track "Governance" tab show/hide in OptionsModel

ef0a787

qt: use show/hide for "Masternodes" tab to avoid client restart

765213c

refactor: track "Masternodes" tab show/hide in OptionsModel

a4d51e2

refactor: repurpose transactiondescdialog as a generic desc. container

8265b49

qt: reorder columns in "Governance" tab, make width elastic for key cols

bd2979b

qt: change layout of "Governance" tab controls for readability

4166586

Review with `git log -p -n1 --ignore-space-change --color-moved=dimmed_zebra`.

qt: report compact voting status and expanded details in tooltip

d24ecbb

qt: use monospace font for hashes in "Governance" tab

db6deb7

qt: report proposal info using QTextEdit instead of an alert with JSON

86b9f5e

This is closer to how we report details for transactions and more translation-friendly and easier to copy.

qt: report more proposal information in description, calculate payments

f4bd648

qt: cleanup proposal context menu, add copy JSON and visit URL options

5473a74

Visiting URLs could be dangerous, add a warning before we open a link in someone's browser.

qt: replace "Active" column with icons that reflect lifecycle status

2feba7f

qt: increment in-progress icon progression based on time within cycle

9f2d8dc

fix: pre-calculate icons to avoid resize stutter

86063b3

qt: list locally recorded proposals in "Governance" tab

7b72a2f

qt: add blank canvas if there's no proposals to display

af9f09f

qt: adjust layout of details page of proposal wizard to resemble DGT

6d0bc31

Dash Governance Tools' budget generator is a much more visually friendly design and we can model our wizard after it.

kwvg added 21 commits January 29, 2026 01:44

qt: drop JSON/hex confirmation page, use description dialogs instead

4a75714

The JSON and payload hex means little for the vast majority of users, what matters is the error messages, so we responsively validate contents and drop an extra panel in the process.

qt: use SendConfirmationDialog instead of QMessageBox for confirm

4014ea0

The visual language should match other coin-spending activities, also warn that that you don't get the fee back.

qt: add "Resume Proposal" button for post-confirmation broadcast

d386673

This replaces the remaining pages of the proposal wizard that we removed in the last commit.

qt: disable proposal buttons until synced, creation button w/o funds

781c4b3

You cannot create a proposal without an adequate balance, it's a bad idea to allow any kind of proposal manipulation without being synced.

qt: simplify reconcile() routine, discard old data wholesale.

55cc251

This is a more inexpensive operation since we aren't getting a diff set, we're getting the whole list repeatedly.

refactor: qt/proposalwizard.{cpp,h} -> qt/proposalcreate.{cpp,h}

de9cb71

We are no longer using the wizard format so the name is a misnomer, the logic is also relatively simplified (as now half of it is in `qt/proposalresume.{cpp,h}`)

fix: avoid double-free by clearing before dtor semaphore cleanup

697ced0

fix: check for llmq_ctx before accessing isman

4b76d4f

fix(qt): align headers in debug window's information tab

b9aa5a6

Applying our font causes drift to be introduced for some reason if baked into the layout but this doesn't seem to be an issue if done programmatically

refactor(qt): move debug window stats to separate information widget

18219ea

Review with `git log -p -n1 --color-moved=dimmed_zebra`.

refactor(qt): move Dash-specific reporting to network widget

ddc2d61

Review with `git log -p -n1 --color-moved=dimmed_zebra`.

chore(qt): update header and label descriptions based on capability

e53c5c3

feat(qt): report pending and awaiting islocks, unprotected transactions

bb71e41

trivial(qt): report chainlock time to maintain parity with block fields

f1d1821

feat(qt): report credit pool diff, limit, locked and pending unlocks

c383cbc

feat(qt): report active quorums and their health

2c230e4

refactor(qt): use horizontal layout with vertical grids, reorder data

dd6e20b

Review with `git log -p -n1 --color-moved=dimmed_zebra`.

feat(qt): report governance information

dc6e788

feat(qt): add donut chart to show proposal usage of overall budget

e7c786d

fix: throttle chart updates to one second to prevent lag when syncing

04e171d

kwvg force-pushed the info_refresh branch from 93497db to 04e171d Compare January 28, 2026 20:17

github-actions bot added the needs rebase label Feb 3, 2026

kwvg mentioned this pull request Feb 12, 2026

fix(qt): avoid precision loss when generating proposal, use UniValue instead of QJsonObject, consistency in tab hiding behavior, minor bugfixes #7134

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(qt): UI refresh (4/n, introduce distinct widgets for Dash-specific reporting in debug window, governance stats)#7118

feat(qt): UI refresh (4/n, introduce distinct widgets for Dash-specific reporting in debug window, governance stats)#7118
kwvg wants to merge 49 commits intodashpay:developfrom
kwvg:info_refresh

kwvg commented Jan 28, 2026

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

thephez commented Jan 28, 2026

Uh oh!

github-actions bot commented Feb 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

kwvg commented Jan 28, 2026

Additional Information

Breaking Changes

Checklist

Uh oh!

github-actions bot commented Jan 28, 2026

⚠️ Potential Merge Conflicts Detected

Uh oh!

thephez commented Jan 28, 2026

Uh oh!

github-actions bot commented Feb 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants