fix(qt): avoid precision loss when generating proposal, use UniValue instead of QJsonObject, consistency in tab hiding behavior, minor bugfixes

[kwvg]

Additional Information

Resolution of preexisting bugs in develop, review feedback from dash#7112 and dash#7116 and fixes for bugs discovered when working on dash#7118.

Breaking Changes

None expected.

Checklist

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests (note: N/A)
• I have made corresponding changes to the documentation (note: N/A)
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

[github-actions]

⚠️ Potential Merge Conflicts Detected

This PR has potential conflicts with the following open PRs:

• feat(qt): UI refresh (2/n, update "Governance" Tab layout, lifecycle icons, description dialogs, resumable proposal creation) #7110 - feat(qt): UI refresh (2/n, update "Governance" Tab layout, lifecycle icons, description dialogs, resumable proposal creation)

Please coordinate with the authors of these PRs to avoid merge conflicts.

[coderabbitai]

Walkthrough

Added a new int64_t targetSpacing field to GOV::GovernanceInfo and propagated its use into proposal creation (ProposalWizard now constructed with WalletModel* and reads governance fields instead of a Node reference). Introduced Wallet::signGovernanceVote and a WalletImpl override; governancelist now calls wallet().signGovernanceVote. Qt UI: Proposal amounts use CAmount and display-unit signaling; proposal JSON uses UniValue with 64-bit epoch arithmetic; ProposalWizard is non-blocking. Masternode UI migrated std::set/std::map to QSet/QHash and changed updateDIP3List() to return bool. Networking StopNodes/Stop locking now clears reconnections under m_reconnections_mutex.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~30 minutes

Possibly related PRs

• feat(qt): add governance voting functionality to Qt wallet #6690 — modifies governance voting and wallet vote-signing APIs and governance UI.

Suggested reviewers

• knst
• UdjinM6

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 12.50% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes multiple main changes: precision loss fix, UniValue usage, tab hiding consistency, and bugfixes in the proposal generation and Qt code.
Description check	✅ Passed	The description is directly related to the changeset, explaining the context (resolving preexisting bugs and review feedback) and noting that tests/docs are N/A where applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments

src/qt/governancelist.cpp (1)

152-166: Multiple simultaneous wizard instances possible with modeless dialog.

Since the dialog is now modeless, clicking "Create Proposal" multiple times will open multiple independent wizard windows. Consider tracking the wizard pointer (e.g., as a QPointer<ProposalWizard> member) and either raising the existing window or disabling the button while one is open, to prevent accidental duplicate submissions.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@src/qt/masternodelist.cpp`:
- Around line 186-194: The code clears m_mn_list_changed with exchange(false)
before calling updateDIP3List(), which prevents retries if updateDIP3List()
returns early; change the logic so you only clear the flag after a confirmed
successful update (or re-arm it if updateDIP3List() indicates it didn't
complete). Concretely, instead of m_mn_list_changed.exchange(false) at the top,
atomically test (load) the flag, call updateDIP3List() when set, and only call
m_mn_list_changed.store(false) (or leave cleared) after updateDIP3List() returns
success; if updateDIP3List() returns early/failure, ensure you set
m_mn_list_changed.store(true, std::memory_order_relaxed) so the "try again
later" path remains enabled. Use the existing symbols m_mn_list_changed,
updateDIP3List(), and the surrounding timing variables (nMnListUpdateSecods,
nSecondsToWait) to locate and update the conditional flow.

[PastaPastaPasta]

lgtm

[UdjinM6]

utACK 3329898

[knst]

utACK 3329898