change require format so it is always attempted, which won't confuse …#120
Open
smmccabe wants to merge 1 commit intocomponent-driven:masterfrom
Open
change require format so it is always attempted, which won't confuse …#120smmccabe wants to merge 1 commit intocomponent-driven:masterfrom
smmccabe wants to merge 1 commit intocomponent-driven:masterfrom
Conversation
13 tasks
surbhirverma
approved these changes
Aug 11, 2022
|
this fixes issue for me in cypress axe. Can we get this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Webpack 5 throws
Critical dependency: require function is used in a way in which dependencies cannot be statically extractedwhen used with cypress-axe. This PR changes the flow so that require is always attempted within a try/catch as opposed to a conditional, which doesn't upset webpack.I don't understand why there would ever be a situation where require doesn't exist, but this should still work in that case.
fixes #106