chore(deps): update cypress webpack-dev-server packages#5014
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 900a962:
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Parsium
previously approved these changes
Apr 4, 2022
divyajindel
previously approved these changes
Apr 4, 2022
samtjo
force-pushed
the
FE-5113_package_upgrades
branch
from
f138dfe to
900a962
Compare
DipperTheDan
approved these changes
Apr 4, 2022
grabkowski
approved these changes
Apr 4, 2022
divyajindel
approved these changes
Apr 4, 2022
Collaborator
|
🎉 This PR is included in version 105.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
@cypress/webpack-dev-server. See their changelog for details.webpack-dev-servercypress-axecauses the warningCritical dependency: require function is used in a way in which dependencies cannot be statically extractedto appear in the browser in an overlay. There is a PR to fix that bug but I'm not sure when that will be merged. Note the description on the issue is wrong, the same error happens with Webpack 4, not just Webpack 5.Current behaviour
We have 6 open Dependabot alerts for the
node-forgepackage. This is a dependency ofwebpack-dev-serverwhich we only use directly through@cypress/webpack-dev-server.Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions
The following CodeSandbox is an example of the broken behaviour.
You can see the new behaviour by looking at the version in the comment by
codesandbox[bot].