fix: rdkafka sys version range#268
Merged
Lazzaretti merged 1 commit intocloudevents:mainfrom Mar 21, 2026
Merged
Conversation
new versions don't work the same (they need curl) Signed-off-by: Fabrizio Lazzaretti <fabrizio@lazzaretti.me>
There was a problem hiding this comment.
Pull request overview
This pull request attempts to fix a version compatibility issue with the rdkafka-sys package used by the Kafka protocol binding. The change restricts rdkafka-sys to versions below 4.10, reportedly because newer versions require curl as a dependency.
Changes:
- Adds
rdkafka-systo therdkafkafeature dependencies (line 30) - Adds a new optional dependency
rdkafka-syswith version constraint<4.10(line 52)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new versions don't work the same (they need curl)