Skip to content

Update rdkafka version and fix lint warning#265

Open
FalkWoldmann wants to merge 1 commit intocloudevents:mainfrom
FalkWoldmann:main
Open

Update rdkafka version and fix lint warning#265
FalkWoldmann wants to merge 1 commit intocloudevents:mainfrom
FalkWoldmann:main

Conversation

@FalkWoldmann
Copy link
Copy Markdown
Contributor

...you know the drill ;)

See #257

Signed-off-by: Falk Woldmann Lu <52786457+FalkWoldmann@users.noreply.github.com>
@FalkWoldmann
Copy link
Copy Markdown
Contributor Author

Hmm, I guess we need to include curl in the CI/CD? We could also link curl statically, which should work OOTB and should be less headache for the users

@Lazzaretti
Copy link
Copy Markdown
Member

Hmm, I guess we need to include curl in the CI/CD? We could also link curl statically, which should work OOTB and should be less headache for the users

Thanks for your PR and for pointing out the problem! I've added a quick fix to pin rdkafka-sys to <4.10 for now: #268 The root cause is an upstream librdkafka issue where curl.h is included unconditionally even when WITH_CURL=0. There's a fix pending:

I'd prefer to wait for the upstream fix rather than adding curl as a CI dependency or linking it statically, since that would add an unnecessary dependency for users who don't need OIDC/OAuth features. Once rdkafka-sys releases a fixed version, we can bump the constraint.

What do you think @FalkWoldmann is this fine for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants