Conversation
This was referenced Mar 12, 2026
shikanime
force-pushed
the
pr1995
branch
6 times, most recently
from
17891b4 to
0e4adbe
Compare
Contributor
Author
|
@StephaneTrebel Pas besoin d'une vrai review, je voudrais avoir ton avis sur la direction et voir ce que je devrais faire differement |
shikanime
force-pushed
the
pr1995
branch
10 times, most recently
from
b69f23c to
51696fe
Compare
shikanime
force-pushed
the
pr1995
branch
8 times, most recently
from
72bd97c to
7340cbf
Compare
StephaneTrebel
requested changes
Mar 13, 2026
|
|
||
| @OnEvent('project.upsert') | ||
| async handleUpsert(project: ProjectWithDetails) { | ||
| return tracer.startActiveSpan('handleUpsert', async (span) => { |
Collaborator
There was a problem hiding this comment.
suggestion(blocker): Oulà c'est bien lourd, tout ça, et ça obfusque la vraie signature de la fonction. On serait mieux avisé d'avoir un décorateur pour ça, non ?
Collaborator
C'est pas mal du tout 👍
|
shikanime
commented
Mar 13, 2026
| ) | ||
| } | ||
| await prisma.$connect() | ||
| await this.prisma.$connect() |
Contributor
Author
There was a problem hiding this comment.
We should let the prisma service handle it
apps/server-nestjs/src/modules/keycloak/keycloak-controller.service.spec.ts
Outdated
Show resolved
Hide resolved
shikanime
force-pushed
the
pr1995
branch
3 times, most recently
from
50df5fe to
8e29c2f
Compare
Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: William Phetsinorath william.phetsinorath-open@interieur.gouv.fr
Stack created with Sapling. Best reviewed with ReviewStack.